Skip to content

fix(ci): increase test-server-root-path timeout to 30m - #25741

Merged
yuneng-berri merged 1 commit into
BerriAI:mainfrom
joereyna:fix/test-server-root-path-timeout
Apr 15, 2026
Merged

fix(ci): increase test-server-root-path timeout to 30m#25741
yuneng-berri merged 1 commit into
BerriAI:mainfrom
joereyna:fix/test-server-root-path-timeout

Conversation

@joereyna

Copy link
Copy Markdown
Contributor

Summary

  • The test-server-root-path workflow has a 15-minute job timeout that's too tight for cold runners
  • Setup overhead (~75s) + Docker build (~13m 45s) exceeds the limit, causing the build step to be cancelled mid-run
  • Both matrix jobs (/api/v1 and /llmproxy) are affected, resulting in spurious cancellations across multiple PRs

Fix

Increase timeout-minutes from 15 to 30 to give the Docker build sufficient headroom on cold runners.

@joereyna
joereyna requested a review from a team April 15, 2026 02:43
@vercel

vercel Bot commented Apr 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Apr 15, 2026 2:45am

Request Review

@greptile-apps

greptile-apps Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR increases the timeout-minutes for the test-server-root-path workflow from 15 to 30 to prevent spurious job cancellations on cold runners where Docker build time alone (~14m) consumes nearly the full existing budget. The change is minimal, well-justified, and correctly scoped to only the job-level timeout.

Confidence Score: 5/5

Safe to merge — single-value CI timeout adjustment with no functional or security impact.

The change is a one-line increase to a CI timeout with a clear, well-documented rationale. No logic, security, or correctness concerns.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/test_server_root_path.yml Single-line change: timeout-minutes increased from 15 to 30 to give Docker builds on cold runners sufficient headroom.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Triggered] --> B[test-server-root-path job\ntimeout: 30m]
    B --> C{Matrix Strategy}
    C --> D[root_path: /api/v1]
    C --> E[root_path: /llmproxy]
    D --> F[Checkout + Free Disk Space\n~75s]
    E --> F2[Checkout + Free Disk Space\n~75s]
    F --> G[Docker Build\n~14m on cold runner]
    F2 --> G2[Docker Build\n~14m on cold runner]
    G --> H[Start Container]
    G2 --> H2[Start Container]
    H --> I[Wait for Healthy]
    H2 --> I2[Wait for Healthy]
    I --> J[Test UI Endpoint]
    I2 --> J2[Test UI Endpoint]
    J --> K[Cleanup]
    J2 --> K2[Cleanup]
Loading

Reviews (1): Last reviewed commit: "fix(ci): increase test-server-root-path ..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing joereyna:fix/test-server-root-path-timeout (ccbdaa9) with main (5c1f7d9)

Open in CodSpeed

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@krrish-berri-2
krrish-berri-2 enabled auto-merge (squash) April 15, 2026 02:52
@krrish-berri-2
krrish-berri-2 disabled auto-merge April 15, 2026 02:52
@yuneng-berri
yuneng-berri merged commit bdb4f39 into BerriAI:main Apr 15, 2026
50 of 52 checks passed
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
…ath-timeout

fix(ci): increase test-server-root-path timeout to 30m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants