Skip to content

fix: remove non-existent litellm_mcps_tests_coverage from coverage combine - #25737

Merged
yuneng-berri merged 1 commit into
BerriAI:mainfrom
joereyna:fix/remove-missing-mcps-coverage-path
Apr 15, 2026
Merged

fix: remove non-existent litellm_mcps_tests_coverage from coverage combine#25737
yuneng-berri merged 1 commit into
BerriAI:mainfrom
joereyna:fix/remove-missing-mcps-coverage-path

Conversation

@joereyna

Copy link
Copy Markdown
Contributor

Summary

  • Removes litellm_mcps_tests_coverage from the coverage combine command in .circleci/config.yml
  • This path was never produced by any CI job, causing the upload-coverage step to consistently fail with Couldn't combine from non-existent path 'litellm_mcps_tests_coverage'

Test plan

  • Verify upload-coverage CircleCI job passes after this change

@joereyna
joereyna requested a review from a team April 15, 2026 02:02
@vercel

vercel Bot commented Apr 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Apr 15, 2026 2:04am

Request Review

@greptile-apps

greptile-apps Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes litellm_mcps_tests_coverage from the coverage combine command in the upload-coverage CircleCI job. A grep of the full config confirms no job ever produces this path, while the related mcp_coverage artifact (produced on line 779) remains correctly included.

Confidence Score: 5/5

Safe to merge — removes a non-existent path that was breaking the upload-coverage CI step, with no other side effects.

Single-line CI config fix that removes a path never produced by any job. Confirmed via full-config grep that litellm_mcps_tests_coverage has no corresponding producer, and mcp_coverage is correctly retained. No logic or code changes.

No files require special attention.

Important Files Changed

Filename Overview
.circleci/config.yml Removes litellm_mcps_tests_coverage from the coverage combine command — confirmed no CI job produces this path, while the related mcp_coverage path is correctly retained.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Jobs Produce Coverage Artifacts] --> B[realtime_translation_coverage]
    A --> C[ocr_coverage]
    A --> D[search_coverage]
    A --> E[mcp_coverage]
    A --> F[logging_coverage]
    A --> G[audio_coverage]
    A --> H[local_testing_part1/2_coverage]
    A --> I[pass_through_unit_tests_coverage]
    A --> J[batches_coverage]
    A --> K[guardrails_coverage]
    A --> L[redis_caching_coverage]
    A --> X[litellm_mcps_tests_coverage - Never produced]

    B & C & D & E & F & G & H & I & J & K & L --> M[coverage combine]
    X -. was incorrectly referenced .-> M
    M --> N[coverage xml]
    N --> O[codecov upload]

    style X fill:#ffcccc,stroke:#cc0000
    style M fill:#ccffcc,stroke:#00aa00
Loading

Reviews (1): Last reviewed commit: "fix: remove non-existent litellm_mcps_te..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing joereyna:fix/remove-missing-mcps-coverage-path (a01cf44) with main (5c1f7d9)

Open in CodSpeed

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yuneng-berri
yuneng-berri merged commit 3284dee into BerriAI:main Apr 15, 2026
49 of 52 checks passed
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
…s-coverage-path

fix: remove non-existent litellm_mcps_tests_coverage from coverage combine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants