Skip to content

Revert "fix(embedding): omit null encoding_format for openai requests" #25698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sameerlite merged 1 commit into from
Apr 14, 2026
Merged

Revert "fix(embedding): omit null encoding_format for openai requests" #25698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions litellm/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4913,6 +4913,9 @@ def embedding( # noqa: PLR0915

if encoding_format is not None:
optional_params["encoding_format"] = encoding_format
else:
# Omiting causes openai sdk to add default value of "float"
optional_params["encoding_format"] = None
Comment on lines 4914 to +4918

@greptile-apps greptile-apps Bot Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Comment typo: "Omiting" → "Omitting"

The inline comment has a spelling error that will be seen by every future reader of this block.

Suggested change
if encoding_format is not None:
optional_params["encoding_format"] = encoding_format
else:
# Omiting causes openai sdk to add default value of "float"
optional_params["encoding_format"] = None
if encoding_format is not None:
optional_params["encoding_format"] = encoding_format
else:
# Omitting causes openai sdk to add default value of "float"
optional_params["encoding_format"] = None


api_version = None

Expand Down
34 changes: 0 additions & 34 deletions tests/test_litellm/llms/openai/embeddings/test_openai_embeddings_encoding_format.py
View file
Open in desktop

This file was deleted.

Loading