Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(azure/passthrough): populate standard_logging_object via logging hook #25679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(azure/passthrough): populate standard_logging_object via logging hook #25679
Changes from all commits
63281e8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from litellm import encoding,from litellm.llms.openai.chat.gpt_transformation import OpenAIGPTConfig, andfrom litellm.types.utils import ModelResponseare placed inside the method body. CLAUDE.md says to avoid imports within methods and only allow it to break circular imports. If circular-import avoidance is genuinely needed here (as it is in the Bedrock counterpart), adding a brief inline comment explaining why would make the intent clear. Consider moving any imports that are not circular-import-driven to the module level.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messages=[{"role": "user", "content": "no-message-pass-through-endpoint"}]is forwarded tologging_obj.post_call(input=messages, ...). For Azure chat/completions passthrough the real messages are already inrequest_data["messages"], so every Datadog/cost trace will show the placeholder string as the request input instead of the actual conversation. The actual content is still reachable viaadditional_args, but tools that surface the primaryinputfield will silently show wrong data. Usingrequest_data.get("messages", [{"role": "user", "content": "no-message-pass-through-endpoint"}])here would match reality without breaking anything:Uh oh!
There was an error while loading. Please reload this page.