Litellm oss staging 04 02 2026 p1 - #25055
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR is a staging batch that bundles several independent improvements: SAP GenAI Hub orchestration refactoring (modules, grounding/masking/filtering, credential resolution), Gemini Key changes:
Confidence Score: 4/5Safe to merge for new deployments; existing Prometheus scrapers will see a label cardinality break on the 11 metrics in All previously flagged issues are either fixed (org_alias guard, SAP modules discard) or confirmed intentional (SAP first-source-wins credentials). No new P0/P1 issues found. Score is 4 rather than 5 solely because the backwards-incompatible Prometheus label cardinality change from the prior review round remains unaddressed. litellm/types/integrations/prometheus.py — backwards-incompatible label expansion for 11 existing metrics.
|
| Filename | Overview |
|---|---|
| litellm/llms/sap/chat/transformation.py | Major refactor of SAP request transformation: _build_prompt_module now correctly spreads grounding/masking/filtering/translation into the top-level modules dict, fixing the silent-discard bug flagged in prior rounds. |
| litellm/llms/sap/credentials.py | New first-source-wins credential resolution (confirmed intentional per SAP design). Breaking change for users mixing credential sources, but developer has accepted this trade-off. |
| litellm/llms/vertex_ai/gemini/vertex_and_google_ai_studio_gemini.py | Adds service_tier request/response support and refactors chunk_parser into helper methods; response_headers correctly threaded through streaming and non-streaming paths. |
| litellm/llms/vertex_ai/vertex_llm_base.py | Adds support for pluggable (executable-based) external credential source in Vertex AI authentication. |
| litellm/llms/anthropic/chat/handler.py | Forwards logging_obj to client.post() across all call paths; consistent with the pattern used throughout the codebase. |
| litellm/proxy/proxy_server.py | Adds user_api_key_org_alias to request metadata; now consistently guarded with is not None, mirroring the existing org_id guard. |
| litellm/proxy/utils.py | Fixes handle_exception_on_proxy to preserve the exception's own status_code; joins organization_alias column from SQL query. |
| litellm/litellm_core_utils/llm_cost_calc/tool_call_cost_tracking.py | Adds Anthropic server_tool_use.web_search_requests check; is not None guard passes when value is 0 (pre-existing pattern). |
| litellm/types/integrations/prometheus.py | Introduces _org_label_metrics frozenset and injects org labels; backwards-incompatible label cardinality change for existing deployments. |
| tests/test_litellm/llms/sap/chat/test_sap_transformation.py | Comprehensive new test file covering SAP transform_request, grounding, masking, filtering, and streaming; mock-only with no live network calls. |
Reviews (12): Last reviewed commit: "Fix greptile review" | Re-trigger Greptile
e5f7d00 to
3fe23fa
Compare
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/test_litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
CI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes