Skip to content

polish: remove required asterisks from v3 login form fields#24318

Merged
ryan-crabbe merged 1 commit intolitellm_ryan_march_20from
litellm_login_remove_asterisks
Mar 21, 2026
Merged

polish: remove required asterisks from v3 login form fields#24318
ryan-crabbe merged 1 commit intolitellm_ryan_march_20from
litellm_login_remove_asterisks

Conversation

@ryan-crabbe
Copy link
Copy Markdown
Contributor

Type

🧹 Refactoring

Changes

  • Hides the red required-field asterisks (*) on the Username and Password fields on the v3 login page
  • Validation rules remain unchanged both fields are still required on submit

Hide the red asterisk indicators on Username and Password fields
while keeping the validation rules intact.
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Mar 21, 2026 7:34pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 21, 2026

Greptile Summary

This PR makes a minor cosmetic change to the v3 login page, switching requiredMark={true} to requiredMark={false} on the Ant Design Form component to hide the red asterisks next to the Username and Password labels. Validation logic remains fully intact — both fields still enforce required: true via their rules props and will still display error messages on empty submission.

  • Single-character change in LoginPage.tsx: requiredMark={true}requiredMark={false}
  • No impact on form validation, authentication logic, or any other component
  • This is a purely visual/UX polish change with no functional side-effects

Confidence Score: 5/5

  • Safe to merge — a single cosmetic prop change with no impact on logic, validation, or security.
  • The diff is a one-line change toggling an Ant Design form display prop. Validation rules are untouched, and no other logic is affected. There are no rule violations, no regressions, and no side-effects.
  • No files require special attention.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/app/login/LoginPage.tsx Toggles requiredMark from true to false on the login Form to hide asterisk indicators; all validation rules remain unchanged.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User visits /login] --> B[LoginPage renders Form]
    B --> C{requiredMark=false}
    C -->|Visual| D[No asterisks shown on labels]
    C -->|Validation| E[rules: required=true unchanged]
    E --> F[User submits form]
    F --> G{Fields empty?}
    G -->|Yes| H[Ant Design shows error message]
    G -->|No| I[handleSubmit called → loginMutation]
Loading

Last reviewed commit: "Remove required aste..."

@ryan-crabbe ryan-crabbe merged commit d2a0f79 into litellm_ryan_march_20 Mar 21, 2026
35 of 51 checks passed
@ishaan-berri ishaan-berri deleted the litellm_login_remove_asterisks branch March 26, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant