-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix(bedrock): preserve output_config.effort for Claude 4.6 on Invoke API #23971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KevinZhao
wants to merge
1
commit into
BerriAI:main
Choose a base branch
from
KevinZhao:fix/bedrock-invoke-output-config-effort-4-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -419,9 +419,11 @@ def transform_anthropic_messages_request( | |||||
| anthropic_messages_request=anthropic_messages_request, | ||||||
| ) | ||||||
|
|
||||||
| # 5b. Strip `output_config` — Bedrock Invoke doesn't support it | ||||||
| # Fixes: https://github.com/BerriAI/litellm/issues/22797 | ||||||
| anthropic_messages_request.pop("output_config", None) | ||||||
| # 5b. Bedrock Invoke supports output_config (effort) for Claude 4.6+ models, | ||||||
| # but older models do not — strip it to avoid request rejection. | ||||||
| # Ref: https://github.com/BerriAI/litellm/issues/22797 | ||||||
| if not AnthropicModelInfo._is_claude_4_6_model(model): | ||||||
| anthropic_messages_request.pop("output_config", None) | ||||||
|
|
||||||
| # 5a. Remove `custom` field from tools (Bedrock doesn't support it) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The comment label
Suggested change
|
||||||
| # Claude Code sends `custom: {defer_loading: true}` on tool definitions, | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_is_claude_4_6_modelis a hardcoded string-match check. Per the project's custom rule and AGENTS.md §8 ("Do not hardcode model-specific flags"), model capability decisions must be driven bymodel_prices_and_context_window.jsonread viaget_model_info(or an existing helper likesupports_reasoning). Without this, any future model that gainsoutput_config.effortsupport on Bedrock Invoke requires a code change here before users benefit — exactly the problem the rule was written to avoid.All Claude 4.6 models already carry
"supports_reasoning": truein the model-prices JSON, sosupports_reasoning(or a newsupports_output_config_effortflag added to the JSON) could drive this decision without touching the code for future models.This same violation also exists at
litellm/llms/bedrock/messages/invoke_transformations/anthropic_claude3_transformation.py:425.Rule Used: What: Do not hardcode model-specific flags in the ... (source)