-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Litellm ryan march 16 #23822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Litellm ryan march 16 #23822
Changes from 12 commits
6970e10
c60f1dd
c95783e
4f2fe33
016667b
5befc02
8695171
67482db
12facb2
0d45b1d
c098eca
cde28aa
302292c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4262,7 +4262,7 @@ class DefaultInternalUserParams(LiteLLMPydanticObjectBase): | |||||
| LitellmUserRoles.PROXY_ADMIN_VIEW_ONLY, | ||||||
| ] | ||||||
| ] = Field( | ||||||
| default=LitellmUserRoles.INTERNAL_USER, | ||||||
| default=LitellmUserRoles.INTERNAL_USER_VIEW_ONLY, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The default for Any deployment that has Per the repository's policy on backwards-incompatible changes, this should be guarded by a user-controlled flag (e.g., check whether the user has explicitly set
Suggested change
(If this change is intentional and the SSO/SCIM/JWT paths were the only ones ever used in practice, please add a note in the PR description and a Rule Used: What: avoid backwards-incompatible changes without... (source) |
||||||
| description="Default role assigned to new users created", | ||||||
| ) | ||||||
| max_budget: Optional[float] = Field( | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xml.etree.ElementTree.fromstring()does not protect against "billion laughs" / XML entity expansion attacks. SinceLITELLM_BLOG_POSTS_URLis user-configurable via environment variable, a malicious XML payload at a custom URL could cause excessive memory/CPU consumption.Consider replacing the standard library parser with
defusedxml, which is already a common dependency in Python security-conscious projects:This is a drop-in replacement — no other code changes are needed. The rest of the parsing logic remains identical.