-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[Fix] UI - Logs: Empty Filter Results Show Stale Data #23792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -199,6 +199,7 @@ def test_router_get_model_info_wildcard_routes(): | |
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.mark.flaky(retries=3, delay=1) | ||
|
Comment on lines
200
to
+202
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Adding Consider instead waiting on the side-effect deterministically, e.g. polling |
||
| async def test_router_get_model_group_usage_wildcard_routes(): | ||
| os.environ["LITELLM_LOCAL_MODEL_COST_MAP"] = "True" | ||
| litellm.model_cost = litellm.get_model_cost_map(url="") | ||
|
|
@@ -219,7 +220,7 @@ async def test_router_get_model_group_usage_wildcard_routes(): | |
| ) | ||
| print(resp) | ||
|
|
||
| await asyncio.sleep(1) | ||
| await asyncio.sleep(2) | ||
|
|
||
| tpm, rpm = await router.get_model_group_usage(model_group="gemini/gemini-1.5-flash") | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pricing check may miss non-token cost types
The guard for whether the
router_model_identry has real pricing only checksinput_cost_per_tokenandinput_cost_per_second. There are other pricing dimensions inmodel_prices_and_context_window.json— e.g.input_cost_per_audio_token,input_cost_per_image_token,input_cost_per_character— that would cause the condition to evaluate toFalseeven when the entry does have meaningful custom pricing, silently falling back to the model name and potentially returning the wrong cost.Consider broadening the guard to cover all known input cost fields: