Skip to content

fix: add missing capability fields for gpt-5.4 variants #23645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −0
Open

fix: add missing capability fields for gpt-5.4 variants #23645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions litellm/model_prices_and_context_window_backup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4344,6 +4344,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4386,6 +4388,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4421,6 +4425,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": false,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4456,6 +4462,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": false,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -16690,6 +16698,10 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
Comment on lines +16701 to +16704
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same duplicate-key bug in backup file

This file has the identical duplicate-key problem for global.anthropic.claude-sonnet-4-5-20250929-v1:0:

"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,

The fix here is the same — remove the first (false) pair and retain only the intended values:

Suggested change
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,

"supports_response_schema": true,
"supports_tool_choice": true,
"supports_vision": true,
Expand Down Expand Up @@ -18645,6 +18657,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down
14 changes: 14 additions & 0 deletions model_prices_and_context_window.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4344,6 +4344,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4386,6 +4388,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4421,6 +4425,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": false,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -4456,6 +4462,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": false,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down Expand Up @@ -16690,6 +16698,10 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
Comment on lines +16701 to +16704
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove conflicting duplicate capability flags

This change adds supports_none_reasoning_effort and supports_xhigh_reasoning_effort twice (with contradictory values) inside the global.anthropic.claude-sonnet-4-5-20250929-v1:0 object, even though the commit is scoped to GPT-5.4 variants. Duplicate JSON keys are parser-dependent (first wins, last wins, or rejection), so this can make Claude capability detection inconsistent across environments and accidentally alter reasoning-effort behavior for this Bedrock model.

Useful? React with 👍 / 👎.

Comment on lines +16701 to +16704
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate JSON keys for wrong model entry

The global.anthropic.claude-sonnet-4-5-20250929-v1:0 model entry now contains two conflicting entries for both supports_none_reasoning_effort and supports_xhigh_reasoning_effort:

"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,

Duplicate keys are not valid per the JSON specification (RFC 8259). While Python's json.loads() silently uses the last-defined value (true), strict JSON parsers will reject this, and linters/validators will flag it. The intended final state appears to be true for both, so the first duplicate pair should be removed:

Suggested change
"supports_none_reasoning_effort": false,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,

Additionally, this model (global.anthropic.claude-sonnet-4-5-20250929-v1:0) is a Claude Sonnet 4.5 Bedrock entry, not a gpt-5.4 variant — it appears to have been modified unintentionally by this PR. The same duplicate-key issue exists at the same line range in litellm/model_prices_and_context_window_backup.json.

"supports_response_schema": true,
"supports_tool_choice": true,
"supports_vision": true,
Expand Down Expand Up @@ -18645,6 +18657,8 @@
"supports_pdf_input": true,
"supports_prompt_caching": true,
"supports_reasoning": true,
"supports_none_reasoning_effort": true,
"supports_xhigh_reasoning_effort": true,
"supports_response_schema": true,
"supports_system_messages": true,
"supports_tool_choice": true,
Expand Down
Loading