-
-
Notifications
You must be signed in to change notification settings - Fork 11k
fix: correct wandb model prices (off by ~100,000x) #23521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+31
−44
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change removes multimodal pricing for
vertex_ai/gemini-embedding-2-previewThis PR's stated purpose is to fix wandb model pricing, but this hunk also overwrites the
vertex_ai/gemini-embedding-2-previewentry in a way that drops the multimodal cost fields that were present before:It also changes the
input_cost_per_tokenfrom2e-07(sourced from Google Cloud Vertex AI pricing) to1.5e-07(sourced from the Gemini API docs) and points thesourceURL to the Gemini API documentation instead of the Vertex AI pricing page. For avertex_ai/-prefixed model entry, the Vertex AI pricing source is the authoritative reference. Removing the audio/image/video cost fields could silently cause zero-cost billing for multimodal embedding calls on Vertex AI.Please confirm whether these changes are intentional and, if so, document the reasoning. If they were accidentally included (e.g. picked up from a rebase/merge), consider reverting them to keep this PR focused.