-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix(bedrock): normalise streaming choice index=0 for extended-thinkin… #23248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
awais786
wants to merge
1
commit into
BerriAI:main
from
awais786:fix/bedrock-extended-thinking-stream-choice-index
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing assertion on thinking/content delta values
The
test_anthropic_invoke_decoder_thinking_uses_choice_index_zerotest only validateschoices[0].index == 0for all chunks, including thecontent_block_deltachunks that carry actual thinking text ("I should multiply.") and text content ("27 x 453 = 12231"). The existingtest_thinking_block_chunks_use_choice_index_zerocounterpart already assertsdelta.reasoning_contentanddelta.contenton comparable chunks.For completeness and to catch regressions in value propagation through
AmazonAnthropicClaudeStreamDecoder, consider adding content assertions for the delta chunks, e.g.: