Skip to content

fix(budget): log warning on timezone fallback to UTC #23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeeJuOh wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(budget): log warning on timezone fallback to UTC #23018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43972a4
fix(budget): log warning on timezone fallback to UTC
LeeJuOh Feb 22, 2026
e9ffe01
fix(budget): improve timezone fallback warning message
LeeJuOh Feb 22, 2026
383f6d4
test(budget): add test for timezone fallback warning log
LeeJuOh Feb 22, 2026
a9ef3cd
test(budget): validate warning message content in timezone fallback test
LeeJuOh Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion litellm/litellm_core_utils/duration_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
from typing import Optional, Tuple
from zoneinfo import ZoneInfo

from litellm._logging import verbose_logger


def _extract_from_regex(duration: str) -> Tuple[int, str]:
match = re.match(r"(\d+)(mo|[smhdw]?)", duration)
Expand Down Expand Up @@ -156,7 +158,11 @@ def _setup_timezone(
else:
tz = ZoneInfo(timezone_str)
except Exception:
# If timezone is invalid, fall back to UTC
verbose_logger.warning(
"Failed to load timezone '%s', falling back to UTC. "
"Check that the timezone is valid and that the 'tzdata' package is installed.",
timezone_str,
)
tz = timezone.utc

# Convert current_time to the target timezone
Expand Down
10 changes: 10 additions & 0 deletions tests/test_litellm/litellm_core_utils/test_duration_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import unittest
from datetime import datetime, timezone
from unittest.mock import patch
from zoneinfo import ZoneInfo

from litellm.litellm_core_utils.duration_parser import get_next_standardized_reset_time
Expand Down Expand Up @@ -184,5 +185,14 @@ def test_dst_spring_forward(self):
self.assertEqual(result, expected)


def test_invalid_timezone_logs_warning(self):
"""Test that an invalid timezone logs a warning when falling back to UTC."""
base_time = datetime(2023, 5, 15, 14, 0, 0, tzinfo=timezone.utc)
with patch("litellm.litellm_core_utils.duration_parser.verbose_logger") as mock_logger:
get_next_standardized_reset_time("1d", base_time, "NonExistentTimeZone")
mock_logger.warning.assert_called_once()
assert "NonExistentTimeZone" in mock_logger.warning.call_args.args[1]


if __name__ == "__main__":
unittest.main()
Loading