-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
perf: streaming latency improvements — 4 targeted hot-path fixes #22346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a4360af
perf: raise aiohttp connection pool limits (300→1000, 50/host→500)
ishaan-jaff a923d27
perf: skip model_copy() on every chunk — only copy usage-bearing chunks
ishaan-jaff ebc8ec8
perf: replace list+join O(n²) with str+= O(n) in async_data_generator
ishaan-jaff 5f2b7bc
perf: cache model-level guardrail lookup per request, not per chunk
ishaan-jaff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cache scope is per-chunk, not per-request
The comment says "Cache model-level guardrails check per-request" but the variables
_cached_guardrail_dataand_guardrail_data_computedare local toasync_post_call_streaming_hook, which is called once per chunk (fromasync_data_generator). So the cache is only effective within a single invocation — it avoids calling_check_and_merge_model_level_guardrails()once perCustomGuardrailcallback within the same chunk, but still calls it once per chunk.This is still a useful optimization if there are multiple guardrail callbacks, but the PR description claims it's "computed once per streaming response and cached for the rest," which is not accurate. To truly cache per-request, the cache would need to be stored outside this method (e.g., on
selfor passed in as state from the caller).