Skip to content

fix(tests): add INCOMPLETE to interactions status enum expected values#21943

Merged
jquinter merged 1 commit intoBerriAI:mainfrom
jquinter:fix/interactions-incomplete-status
Feb 23, 2026
Merged

fix(tests): add INCOMPLETE to interactions status enum expected values#21943
jquinter merged 1 commit intoBerriAI:mainfrom
jquinter:fix/interactions-incomplete-status

Conversation

@jquinter
Copy link
Contributor

Summary

  • Google added INCOMPLETE to the Interactions API OpenAPI spec status enum
  • Updated the hardcoded expected values in test_status_enum_values to match the live spec

Test plan

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Feb 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Feb 23, 2026 6:09pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Greptile Summary

Adds the INCOMPLETE status value to the Status3 (aliased as InteractionStatus) enum in the generated types for Google's Interactions API, and updates the corresponding OpenAPI compliance test to expect this new value. This aligns the SDK with Google's updated Interactions API OpenAPI spec.

  • Added INCOMPLETE = 'INCOMPLETE' to Status3 enum in litellm/types/interactions/generated.py
  • Updated test_status_enum_values expected values list in the compliance test to include INCOMPLETE
  • Both the type and test are updated together, ensuring the SDK can correctly deserialize responses containing the new status

Confidence Score: 5/5

  • This PR is safe to merge — it adds a single enum value to match an upstream API spec change, with a corresponding test update.
  • The change is minimal and well-scoped: one new enum member added to an existing enum, and one test assertion updated to match. Both files are consistent with each other. The type is used only in the interactions module and poses no risk of regression. The upstream spec change is verified.
  • No files require special attention.

Important Files Changed

Filename Overview
litellm/types/interactions/generated.py Adds INCOMPLETE = 'INCOMPLETE' to the Status3 enum, aligning the type with the upstream Google Interactions API spec. No issues found.
tests/test_litellm/interactions/test_openapi_compliance.py Updates the hardcoded expected status enum values to include INCOMPLETE, matching the live OpenAPI spec. No issues found.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Google Interactions API\n(upstream spec)"] -->|"adds INCOMPLETE status"| B["litellm/types/interactions/generated.py\nStatus3 enum"]
    B -->|"exported as"| C["InteractionStatus\n(__init__.py alias)"]
    C -->|"used by"| D["CreateModelInteractionParams\n(status field)"]
    C -->|"used by"| E["CreateAgentInteractionParams\n(status field)"]
    B -->|"validated by"| F["test_openapi_compliance.py\ntest_status_enum_values"]
Loading

Last reviewed commit: f94d0fe

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Google added INCOMPLETE to the Interactions API OpenAPI spec status enum.
Update both the Status3 enum in the SDK types and the test's expected
values to match.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jquinter jquinter force-pushed the fix/interactions-incomplete-status branch from 61ebd76 to f94d0fe Compare February 23, 2026 18:07
@jquinter
Copy link
Contributor Author

@greptile-apps re-review this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@jquinter jquinter merged commit 3681319 into BerriAI:main Feb 23, 2026
30 checks passed
damhau pushed a commit to damhau/litellm that referenced this pull request Feb 26, 2026
…plete-status

fix(tests): add INCOMPLETE to interactions status enum expected values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant