Skip to content

fix(tests): make RPM limit test sequential to fix race condition #21937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jquinter merged 1 commit into from
Feb 23, 2026
Merged

fix(tests): make RPM limit test sequential to fix race condition #21937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions tests/local_testing/test_pass_through_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,22 +223,17 @@ async def test_pass_through_endpoint_rpm_limit(
],
}

# Make a request to the pass-through endpoint
tasks = []
# Make requests sequentially to avoid race conditions in rate limiter
# Concurrent requests can slip through before the counter is updated
responses = []
for mock_api_key in mock_api_keys:
for _ in range(requests_to_make):
task = asyncio.get_running_loop().run_in_executor(
None,
partial(
client.post,
"/v1/rerank",
json=_json_data,
headers={"Authorization": "Bearer {}".format(mock_api_key)},
),
response = client.post(
"/v1/rerank",
json=_json_data,
headers={"Authorization": "Bearer {}".format(mock_api_key)},
)
tasks.append(task)

responses = await asyncio.gather(*tasks)
responses.append(response)

if num_users == 1:
status_codes = sorted([response.status_code for response in responses])
Expand Down
Loading