Skip to content

[Doc] Server Root Path Regression Incident Doc#21853

Closed
yuneng-jiang wants to merge 7 commits intomainfrom
doc_yj_feb21
Closed

[Doc] Server Root Path Regression Incident Doc#21853
yuneng-jiang wants to merge 7 commits intomainfrom
doc_yj_feb21

Conversation

@yuneng-jiang
Copy link
Collaborator

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

CI (LiteLLM team)

CI status guideline:

  • 50-55 passing tests: main is stable with minor issues.
  • 45-49 passing tests: acceptable but needs attention
  • <= 40 passing tests: unstable; be careful with your merges and assess the risk.
  • Branch creation CI run
    Link:

  • CI run for the last commit
    Link:

  • Merge / cherry-pick CI run
    Links:

Type

📖 Documentation

Changes

@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Error Error Feb 22, 2026 0:37am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 22, 2026

Greptile Summary

This PR adds a new incident report blog post documenting the SERVER_ROOT_PATH regression that occurred in January 2026. The document follows the same structure and format as existing incident reports (model_cost_map_incident, vllm_embeddings_incident), covering summary, background, root cause, remediation, CI workflow details, timeline, and resolution steps for users.

  • The blog post is well-written with clear mermaid diagrams, a detailed remediation table, and links to the relevant PRs, tests, and CI workflows
  • One syntax issue found: the Docusaurus truncate marker uses incorrect syntax ({/_ truncate _/} instead of {/* truncate */}), which will prevent proper blog listing truncation
  • Referenced files (test_server_root_path.py, test_server_root_path.yml) exist in the repository
  • No code changes — documentation only

Confidence Score: 4/5

  • Documentation-only PR with no code changes; safe to merge after fixing the truncate marker syntax
  • This is a documentation-only change adding a new blog post. The content is well-structured, follows existing patterns, and all referenced resources exist. The only issue is a malformed Docusaurus truncate marker that would affect blog listing display but not site builds.
  • docs/my-website/blog/server_root_path/index.md has a malformed truncate marker on line 36

Important Files Changed

Filename Overview
docs/my-website/blog/server_root_path/index.md New incident report blog post for SERVER_ROOT_PATH regression. Well-structured and follows existing patterns. Has one syntax issue: malformed Docusaurus truncate marker on line 36.

Sequence Diagram

sequenceDiagram
    participant User as User Browser
    participant RP as Reverse Proxy
    participant LP as LiteLLM Proxy (FastAPI)

    User->>RP: GET /llmproxy/ui/
    RP->>LP: GET /ui/ (stripped prefix)

    alt root_path set (before & after fix)
        LP->>LP: FastAPI root_path="/llmproxy"
        LP-->>RP: 200 OK (UI HTML)
        RP-->>User: UI renders correctly
    else root_path missing (during regression)
        LP->>LP: FastAPI root_path=""
        LP-->>RP: 404 Not Found
        RP-->>User: 404 Error
    end
Loading

Last reviewed commit: 2e8d942

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

- **UI pages:** All UI pages returned 404 for deployments using `SERVER_ROOT_PATH`.
- **Swagger/OpenAPI docs:** Broken when accessed through the configured root path.

{/_ truncate _/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malformed Docusaurus truncate marker

The truncate comment uses {/_ truncate _/} but all other blog posts in this repository use {/* truncate */} (standard JSX comment syntax). This malformed marker won't be recognized by Docusaurus, so the blog listing page will display the full article content instead of showing just the summary above the fold.

Suggested change
{/_ truncate _/}
{/* truncate */}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant