Skip to content

fix: add missing return type annotations to iterator protocol methods in streaming_handler #21750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krrishdholakia merged 2 commits into from
Feb 22, 2026
Merged

fix: add missing return type annotations to iterator protocol methods in streaming_handler #21750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d94654
fix: add return type annotations to iterator protocol methods in stre…
WhoisMonesh Feb 21, 2026
ab4d591
fix: add ruff PLR0915 noqa for files with too many statements
WhoisMonesh Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions litellm/litellm_core_utils/streaming_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import threading
import time
import traceback
from typing import Any, Callable, Dict, List, Optional, Union, cast
from typing import Any, AsyncIterator, Callable, Dict, Iterator, List, Optional, Union, cast

import httpx
from pydantic import BaseModel
Expand Down Expand Up @@ -150,10 +150,10 @@ def __init__(
self.is_function_call = self.check_is_function_call(logging_obj=logging_obj)
self.created: Optional[int] = None

def __iter__(self):
def __iter__(self) -> Iterator["ModelResponseStream"]:
return self

def __aiter__(self):
def __aiter__(self) -> AsyncIterator["ModelResponseStream"]:
return self

def check_send_stream_usage(self, stream_options: Optional[dict]):
Expand Down Expand Up @@ -1704,7 +1704,7 @@ def finish_reason_handler(self):
model_response.choices[0].finish_reason = "tool_calls"
return model_response

def __next__(self): # noqa: PLR0915
def __next__(self) -> "ModelResponseStream": # noqa: PLR0915
cache_hit = False
if (
self.custom_llm_provider is not None
Expand Down Expand Up @@ -1878,7 +1878,7 @@ async def fetch_stream(self):

return self.completion_stream

async def __anext__(self): # noqa: PLR0915
async def __anext__(self) -> "ModelResponseStream": # noqa: PLR0915
cache_hit = False
if (
self.custom_llm_provider is not None
Expand Down
5 changes: 4 additions & 1 deletion ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ exclude = ["litellm/types/*", "litellm/__init__.py", "litellm/proxy/example_conf
"litellm/llms/anthropic/chat/__init__.py" = ["F401"]
"litellm/llms/azure_ai/embed/__init__.py" = ["F401"]
"litellm/llms/azure_ai/rerank/__init__.py" = ["F401"]
"litellm/llms/bedrock/chat/__init__.py" = ["F401"]
"litellm/llms/bedrock/chat/__init__.py" = ["F401"]
"litellm/proxy/utils.py" = ["F401", "PLR0915"]
"litellm/proxy/guardrails/guardrail_hooks/litellm_content_filter/content_filter.py" = ["PLR0915"]
"litellm/proxy/guardrails/guardrail_hooks/guardrail_benchmarks/test_eval.py" = ["PLR0915"]
Loading