fix(tests): resolve merge conflict in test_vertex_ai_rerank_transformation.py#21478
Merged
fix(tests): resolve merge conflict in test_vertex_ai_rerank_transformation.py#21478
Conversation
…ation.py The file had two unresolved git merge conflict markers from a merge of litellm_oss_staging_02_17_2026 into main, causing a SyntaxError when pytest tried to collect the test module. Kept the instance-level mocking approach (from litellm_oss_staging) for test_get_complete_url and test_validate_environment, which is consistent with the rest of the file and avoids class-reference issues caused by importlib.reload(litellm) in conftest.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR resolves two unresolved git merge conflict markers in the Vertex AI rerank test file that caused
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| tests/test_litellm/llms/vertex_ai/rerank/test_vertex_ai_rerank_transformation.py | Resolves two unresolved git merge conflict markers (lines 44 and 112) by keeping the instance-level mocking approach from the staging branch, which is resilient to importlib.reload(litellm) in conftest.py. No issues found. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["test_get_complete_url\ntest_validate_environment"] --> B{"Mocking approach?"}
B -->|"Staging branch - kept"| C["Instance-level mock on\nself.config object"]
B -->|"Main branch - removed"| D["Decorator-based patch\non class reference"]
C --> E["Resilient to importlib.reload\nin conftest.py"]
D --> F["Breaks when importlib.reload\ninvalidates class reference"]
E --> G["Tests pass"]
F --> H["Tests fail"]
Last reviewed commit: 419151d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_litellm/llms/vertex_ai/rerank/test_vertex_ai_rerank_transformation.pyhad two unresolved git merge conflict markers (<<<<<<< litellm_oss_staging_02_17_2026/>>>>>>> main) on lines 44 and 112SyntaxError: invalid syntaxat line 44@patchclass-reference issues caused byimportlib.reload(litellm)inconftest.py)Test plan
python -c "import ast; ast.parse(open('tests/test_litellm/llms/vertex_ai/rerank/test_vertex_ai_rerank_transformation.py').read())"poetry run pytest tests/test_litellm/llms/vertex_ai/rerank/test_vertex_ai_rerank_transformation.py -vcollects and runs tests🤖 Generated with Claude Code