Skip to content

fix(ci): add prisma generate step to matrix CI workflow#21436

Merged
jquinter merged 1 commit intomainfrom
fix/prisma-generate-matrix-ci
Feb 18, 2026
Merged

fix(ci): add prisma generate step to matrix CI workflow#21436
jquinter merged 1 commit intomainfrom
fix/prisma-generate-matrix-ci

Conversation

@jquinter
Copy link
Copy Markdown
Contributor

Summary

  • tests/proxy_unit_tests/test_key_generate_prisma.py imports PrismaClient at module level, which triggers a Prisma binary check at collection time
  • The matrix CI workflow installs the prisma Python package (via proxy-dev extras) but never runs prisma generate
  • This causes all tests in that file to ERROR with: Unable to find Prisma binaries. Please run 'prisma generate' first.
  • Fix: add a Generate Prisma client step after dependency installation, using the existing schema at litellm/proxy/schema.prisma

Test plan

  • Verify proxy-unit-a CI job no longer errors on test_key_generate_prisma.py tests

🤖 Generated with Claude Code

tests/proxy_unit_tests/test_key_generate_prisma.py imports PrismaClient
at module level, which triggers a Prisma binary check. Without running
prisma generate first, all tests in that file ERROR at collection time
with "Unable to find Prisma binaries. Please run 'prisma generate' first."

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Feb 18, 2026 1:25am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

This PR adds a prisma generate step to the matrix CI workflow (.github/workflows/test-litellm-matrix.yml) to fix test collection failures in tests/proxy_unit_tests/test_key_generate_prisma.py. The prisma Python package is installed via proxy-dev extras, but without running prisma generate, the Prisma client binaries are missing, causing import-time errors when pytest collects test files that reference PrismaClient.

  • Adds poetry run prisma generate --schema litellm/proxy/schema.prisma as a new step after dependency installation and before test execution
  • This mirrors the pattern used in CircleCI (config.yml) and the devcontainer setup (post-create.sh)
  • Fixes errors in the proxy-unit-a CI job where test_key_generate_prisma.py (and potentially other files importing PrismaClient) would fail at collection time

Confidence Score: 5/5

  • This PR is safe to merge — it adds a single, well-understood CI step that aligns with existing patterns in the repository.
  • The change is a minimal, 4-line addition to a CI workflow file that adds a prisma generate step. The command is correct (poetry run prisma generate --schema litellm/proxy/schema.prisma), the schema path exists, and this pattern is already used in CircleCI and the devcontainer setup. There is no risk to production code, no logic changes, and the fix directly addresses the documented error.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/test-litellm-matrix.yml Adds a prisma generate step after dependency installation and before test execution. The command and schema path are correct and consistent with other CI configurations in the repo.

Flowchart

flowchart TD
    A[Checkout Code] --> B[Setup Python 3.12]
    B --> C[Install Poetry]
    C --> D[Cache Dependencies]
    D --> E[Install Dependencies<br/>poetry install --with dev,proxy-dev]
    E --> F[Setup litellm-enterprise]
    F --> G[Generate Prisma Client<br/>poetry run prisma generate<br/>--schema litellm/proxy/schema.prisma]
    G --> H[Run Tests<br/>poetry run pytest ...]
    style G fill:#90EE90,stroke:#333,stroke-width:2px
Loading

Last reviewed commit: 58f23cb

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@jquinter jquinter merged commit 65a79d5 into main Feb 18, 2026
20 of 26 checks passed
@ishaan-berri ishaan-berri deleted the fix/prisma-generate-matrix-ci branch March 26, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant