fix(deps): add fakeredis for pod lock manager tests#21281
Merged
Conversation
The test file test_e2e_pod_lock_manager.py requires fakeredis but it was not declared as a dev dependency, causing import errors when the test module is loaded. This is a pre-existing issue that was exposed by better test coverage in PR 21277 but is not caused by that PR. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
fakeredisto dev dependencies to fix import error intest_e2e_pod_lock_manager.py.Problem
The test file
tests/proxy_unit_tests/test_e2e_pod_lock_manager.pyimportsfakeredisbut it was never declared as a dev dependency, causing the following error when the test module is loaded:Solution
Added
fakeredis = "^2.27.1"to[tool.poetry.group.dev.dependencies]inpyproject.toml.Related
This is a pre-existing issue that was exposed by better test coverage/organization in PR #21277, but is not caused by that PR. This PR fixes the issue at its source.
🤖 Generated with Claude Code