perf(proxy): remove duplicate daily agent transaction computation

[emerzon]

Summary

This PR removes duplicate work in add_spend_log_transaction_to_daily_agent_transaction().

Before:

• _common_add_spend_log_transaction_to_daily_transaction(...) was called once before agent_id checks and then called a second time again for the same request.

After:

• Validate agent_id first.
• Build payload_with_agent_id once.
• Call _common_add_spend_log_transaction_to_daily_transaction(...) only once.

This eliminates redundant metadata parsing/status computation in the daily agent spend path.

Files Changed

• litellm/proxy/db/db_spend_update_writer.py
• tests/test_litellm/proxy/db/test_db_spend_update_writer.py

Issue

Closes #21181

Validation

• timeout 120s poetry run pytest -q tests/test_litellm/proxy/db/test_db_spend_update_writer.py::test_add_spend_log_transaction_to_daily_agent_transaction_injects_agent_id_and_queues_update tests/test_litellm/proxy/db/test_db_spend_update_writer.py::test_add_spend_log_transaction_to_daily_agent_transaction_calls_common_helper_once tests/test_litellm/proxy/db/test_db_spend_update_writer.py::test_add_spend_log_transaction_to_daily_agent_transaction_skips_when_agent_id_missing

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
litellm	Ready	Preview, Comment	Feb 14, 2026 3:07am

[Copilot]

Pull request overview

This PR optimizes the add_spend_log_transaction_to_daily_agent_transaction() function by removing a duplicate call to _common_add_spend_log_transaction_to_daily_transaction(). The optimization follows the same pattern used by similar functions (add_spend_log_transaction_to_daily_end_user_transaction and add_spend_log_transaction_to_daily_org_transaction) where entity ID validation happens first, followed by a single call to the common helper function.

Changes:

• Removed duplicate call to _common_add_spend_log_transaction_to_daily_transaction() in agent spend tracking
• Added comprehensive test to verify the common helper is called only once
• Minor formatting fix in test file (trailing line)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
litellm/proxy/db/db_spend_update_writer.py	Removed the first (redundant) call to _common_add_spend_log_transaction_to_daily_transaction() that occurred before agent_id validation, eliminating duplicate JSON parsing and status computation
tests/test_litellm/proxy/db/test_db_spend_update_writer.py	Added test test_add_spend_log_transaction_to_daily_agent_transaction_calls_common_helper_once() to verify the fix using AsyncMock wrapping and await_count assertion; minor formatting fix

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR eliminates a redundant call to _common_add_spend_log_transaction_to_daily_transaction() in the daily agent spend tracking path. Previously, the function was called twice — once before and once after validating agent_id — causing duplicate metadata parsing, status computation, and transaction building. The fix reorders the logic to check agent_id first (returning early if None), then calls the common helper exactly once with the validated payload.

• Removed the first (unnecessary) call to _common_add_spend_log_transaction_to_daily_transaction in add_spend_log_transaction_to_daily_agent_transaction
• Moved the agent_id is None early-return check before the common helper call, matching the pattern used in add_spend_log_transaction_to_daily_org_transaction and add_spend_log_transaction_to_daily_end_user_transaction
• Added a new test (test_add_spend_log_transaction_to_daily_agent_transaction_calls_common_helper_once) that verifies the helper is called exactly once
• Fixed missing newline at end of test file

Confidence Score: 5/5

• This PR is safe to merge — it's a minimal, well-scoped performance fix with no functional behavior change.
• The change removes 7 lines of redundant code by reordering validation logic. It follows established patterns already used in sibling functions (add_spend_log_transaction_to_daily_org_transaction, add_spend_log_transaction_to_daily_end_user_transaction). The new test directly validates the fix. No new dependencies, no database changes, no API changes.
• No files require special attention.

Important Files Changed

Filename	Overview
litellm/proxy/db/db_spend_update_writer.py	Removes duplicate call to _common_add_spend_log_transaction_to_daily_transaction in the agent spend path by moving the agent_id null check earlier. No functional change, pure performance improvement.
tests/test_litellm/proxy/db/test_db_spend_update_writer.py	Adds a new test verifying the common helper is called exactly once, plus fixes a missing newline at end of file. All tests use mocks only (no real network calls).

Sequence Diagram

sequenceDiagram
    participant Caller
    participant AgentTx as add_spend_log_transaction_to_daily_agent_transaction
    participant Common as _common_add_spend_log_transaction_to_daily_transaction
    participant Queue as daily_agent_spend_update_queue

    Note over AgentTx: Before (redundant)
    Caller->>AgentTx: payload, prisma_client
    AgentTx->>Common: payload (1st call - wasted if agent_id is None)
    Common-->>AgentTx: base_daily_transaction
    AgentTx->>AgentTx: Check agent_id is None?
    AgentTx->>Common: payload_with_agent_id (2nd call - duplicate work)
    Common-->>AgentTx: base_daily_transaction
    AgentTx->>Queue: add_update(daily_transaction)

    Note over AgentTx: After (optimized)
    Caller->>AgentTx: payload, prisma_client
    AgentTx->>AgentTx: Check agent_id is None? (early return)
    AgentTx->>Common: payload_with_agent_id (single call)
    Common-->>AgentTx: base_daily_transaction
    AgentTx->>Queue: add_update(daily_transaction)

Loading

_{Last reviewed commit: 669eb9d}

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}