Skip to content

fix(mypy): Fix type errors across multiple files#21180

Merged
ishaan-jaff merged 1 commit intomainfrom
litellm_fix_ci_mypy_errors
Feb 14, 2026
Merged

fix(mypy): Fix type errors across multiple files#21180
ishaan-jaff merged 1 commit intomainfrom
litellm_fix_ci_mypy_errors

Conversation

@shin-bot-litellm
Copy link
Contributor

Summary

Fixes mypy type errors in 6 files that were causing CI failures in the mypy_linting job.

Changes

  • litellm/llms/vertex_ai/gemini/transformation.py: Fix TypedDict subscript assignment by using a dict alias with type: ignore
  • litellm/proxy/_experimental/mcp_server/server.py: Convert ASGI scope to dict for type compatibility with MCPDebug helper
  • litellm/proxy/pass_through_endpoints/pass_through_endpoints.py: Add explicit Optional[dict] type annotation for final_custom_body to satisfy mypy
  • litellm/proxy/vector_store_endpoints/endpoints.py: Add Any type annotation for dynamic proxy hook return value
  • litellm/responses/litellm_completion_transformation/transformation.py: Use dict(Reasoning()) for serialization and setattr for dynamic attribute assignment
  • litellm/types/proxy/guardrails/guardrail_hooks/zscaler_ai_guard.py: Add assert for api_base nullability after env var default

Testing

All changes are type annotation fixes only — no runtime behavior changes.

- vertex_ai/gemini/transformation.py: Fix TypedDict assignment via dict alias
- mcp_server/server.py: Convert ASGI scope to dict for type compatibility
- pass_through_endpoints.py: Add explicit Optional[dict] type annotation
- vector_store_endpoints/endpoints.py: Add Any type for dynamic proxy hook
- responses transformation.py: Use dict(Reasoning()) and setattr for compatibility
- zscaler_ai_guard.py: Add assert for api_base nullability
@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Error Error Feb 14, 2026 2:18am

Request Review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


OpenClaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ishaan-jaff ishaan-jaff merged commit f915b15 into main Feb 14, 2026
9 of 22 checks passed
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 14, 2026

Greptile Overview

Greptile Summary

Fixes mypy type errors across 6 files to unblock the mypy_linting CI job. The changes are purely type-annotation fixes with no intended runtime behavior changes. Most fixes are clean and appropriate — notably the pass_through_endpoints.py refactor which simplifies logic while preserving identical behavior, and the mcp_server/server.py dict(scope) conversion which correctly matches the expected Dict parameter type.

  • litellm/llms/vertex_ai/gemini/transformation.py: Aliases TypedDict to plain dict with type: ignore for arbitrary key subscript assignment
  • litellm/proxy/_experimental/mcp_server/server.py: Converts ASGI scope to dict for type compatibility
  • litellm/proxy/pass_through_endpoints/pass_through_endpoints.py: Simplifies final_custom_body logic with explicit Optional[dict] annotation (behavior preserved)
  • litellm/proxy/vector_store_endpoints/endpoints.py: Uses Any to suppress mypy on get_proxy_hook return — erases downstream type checking
  • litellm/responses/litellm_completion_transformation/transformation.py: Uses dict(Reasoning()) and setattr for mypy compatibility with Pydantic extra="allow" model
  • litellm/types/proxy/guardrails/guardrail_hooks/zscaler_ai_guard.py: Adds assert for nullability narrowing — correct but fragile under python -O

Confidence Score: 4/5

  • This PR is safe to merge — all changes are type annotation fixes with no runtime behavior changes.
  • Score of 4 reflects that all changes are type-only fixes that don't alter runtime behavior, and most are clean and appropriate. Minor deductions for the Any annotation in vector_store_endpoints.py which erases type safety, and the assert in zscaler_ai_guard.py which can be stripped in optimized mode — neither are blocking issues but could be improved.
  • litellm/proxy/vector_store_endpoints/endpoints.py uses Any which erases type safety for downstream method calls. litellm/types/proxy/guardrails/guardrail_hooks/zscaler_ai_guard.py uses assert for runtime narrowing which can be stripped by python -O.

Important Files Changed

Filename Overview
litellm/llms/vertex_ai/gemini/transformation.py Aliases TypedDict to plain dict with type: ignore to allow arbitrary key assignment in _pop_and_merge_extra_body. Correct workaround for TypedDict subscript limitations.
litellm/proxy/_experimental/mcp_server/server.py Converts ASGI scope to dict(scope) to match MCPDebug.maybe_build_debug_headers expected Dict parameter type. Correct and safe conversion.
litellm/proxy/pass_through_endpoints/pass_through_endpoints.py Simplifies final_custom_body logic with explicit Optional[dict] annotation and cleaner elif. Behavior is equivalent to the original code.
litellm/proxy/vector_store_endpoints/endpoints.py Uses Any annotation to suppress mypy error on get_proxy_hook return. Works but erases type safety for subsequent method calls on the returned object.
litellm/responses/litellm_completion_transformation/transformation.py Uses dict(Reasoning()) for TypedDict serialization and setattr for dynamic attribute assignment on Pydantic model with extra="allow". Both approaches are functionally correct.
litellm/types/proxy/guardrails/guardrail_hooks/zscaler_ai_guard.py Adds assert api_base is not None for mypy narrowing. Logically correct given the os.getenv default, but assert can be stripped in optimized mode.

Flowchart

flowchart TD
    A[mypy type checker] --> B{Type errors in 6 files}
    B --> C[vertex_ai/transformation.py]
    B --> D[mcp_server/server.py]
    B --> E[pass_through_endpoints.py]
    B --> F[vector_store_endpoints.py]
    B --> G[litellm_completion_transformation.py]
    B --> H[zscaler_ai_guard.py]
    
    C --> C1["TypedDict subscript fix\n(dict alias + type: ignore)"]
    D --> D1["ASGI scope type fix\n(dict conversion)"]
    E --> E1["Optional[dict] annotation\n(simplified logic)"]
    F --> F1["Any annotation\n(erases type safety ⚠️)"]
    G --> G1["dict(Reasoning()) +\nsetattr for dynamic attr"]
    H --> H1["assert not None\n(fragile under -O ⚠️)"]
    
    C1 --> I[mypy passes ✓]
    D1 --> I
    E1 --> I
    F1 --> I
    G1 --> I
    H1 --> I
Loading

Last reviewed commit: 29a3345

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

)

# Check for configuration issues
assert api_base is not None # always set via env default above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert can be stripped in optimized mode

Using assert for runtime type narrowing is fragile because Python's -O flag strips all assert statements. While the logic guarantees api_base is non-None here (due to the os.getenv default), a safer approach for mypy narrowing would be an if guard or a cast:

Suggested change
assert api_base is not None # always set via env default above
if api_base is None: # always set via env default above; narrow for mypy
api_base = "https://api.us1.zseclipse.net/v1/detection/execute-policy"


# Get managed vector stores hook
managed_vector_stores = proxy_logging_obj.get_proxy_hook("managed_vector_stores")
managed_vector_stores: Any = proxy_logging_obj.get_proxy_hook("managed_vector_stores")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any annotation erases type safety

get_proxy_hook() returns Optional[CustomLogger] — a well-typed return value. Annotating the result as Any silences mypy but removes all type checking for subsequent usage of managed_vector_stores (e.g., the acreate_vector_store call on line 247 won't be checked). Consider using cast() or a protocol/interface that describes the expected methods instead:

Suggested change
managed_vector_stores: Any = proxy_logging_obj.get_proxy_hook("managed_vector_stores")
managed_vector_stores = proxy_logging_obj.get_proxy_hook("managed_vector_stores")

If the issue is that CustomLogger doesn't declare acreate_vector_store, the proper fix is to add that method to the CustomLogger base class or create a Protocol that describes the expected interface, then use cast() to narrow the type.

krrishdholakia pushed a commit that referenced this pull request Feb 14, 2026
…ctions (#21192)

* Access groups UI

* new badge changes

* adding tests

* fix: add custom_body parameter to endpoint_func in create_pass_through_route (#20849)

* fix: add custom_body parameter to endpoint_func in create_pass_through_route

The bedrock_proxy_route calls `endpoint_func(custom_body=data)` to
pass a pre-parsed, SigV4-signed request body. However, the
`endpoint_func` closure created by `create_pass_through_route` does
not accept a `custom_body` keyword argument, causing:

    TypeError: endpoint_func() got an unexpected keyword argument 'custom_body'

Add `custom_body: Optional[dict] = None` to both `endpoint_func`
definitions (adapter-based and URL-based). In the URL-based path,
when `custom_body` is provided by the caller, use it instead of
re-parsing the body from the raw request.

Fixes #16999

* Add tests for custom_body handling in create_pass_through_route

Address reviewer feedback on PR #20849:

- Document why the adapter-based endpoint_func accepts custom_body
  for signature compatibility but does not forward it (the underlying
  chat_completion_pass_through_endpoint does not support it).
- Add test_create_pass_through_route_custom_body_url_target: verifies
  that when a caller (e.g. bedrock_proxy_route) supplies custom_body,
  it takes precedence over the body parsed from the raw request.
- Add test_create_pass_through_route_no_custom_body_falls_back:
  verifies that the default path (no custom_body) correctly uses the
  request-parsed body, preserving existing behavior.

Both tests are fully mocked following the project's CONTRIBUTING.md
guidelines and the patterns established in the existing test file.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: themavik <themavik@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* change to model name for backwards compat

* addressing comments

* allow editing of access group names

* fix: populate identity fields in proxy admin JWT early-return path (#21169)

* fix: populate identity fields in proxy admin JWT early-return path

When is_proxy_admin is True, the UserAPIKeyAuth early-return now includes
user_id, team_id, team_alias, team_metadata, org_id, and end_user_id
resolved from the JWT. Previously only user_role and parent_otel_span
were set, causing blank Team Name and Internal User in Request Logs UI.

* test: add unit tests for proxy admin JWT identity fields

* bump: version 0.4.36 → 0.4.37

* migration + build files

* Add pyroscope for observability (#21167)

* Pyroscope: require PYROSCOPE_APP_NAME and PYROSCOPE_SERVER_ADDRESS, add UTF-8 locale hint

- No defaults for PYROSCOPE_APP_NAME or PYROSCOPE_SERVER_ADDRESS; fail at startup if unset when Pyroscope is enabled
- Set LANG/LC_ALL to C.UTF-8 when unset to reduce malformed_profile (invalid UTF-8) rejections
- Startup message suggests PYTHONUTF8=1 if server rejects profiles
- Simplify LITELLM_ENABLE_PYROSCOPE in config_settings; document Pyroscope env vars as required with no default
- Add pyroscope_profiling to sidebar (Alerting & Monitoring)
- pyproject.toml: pyroscope-io as required dep on non-Windows (marker), in proxy extra

* proxy: add PYROSCOPE_SAMPLE_RATE env, use verbose logging, fix int type

- Add optional PYROSCOPE_SAMPLE_RATE env (integer, no default)
- Pass sample_rate to pyroscope.configure() as int for pyroscope-io
- Replace print with verbose_proxy_logger (info/warning)
- Document PYROSCOPE_SAMPLE_RATE in config_settings.md

* Address Greptile PR feedback: Pyroscope optional, docs, tests, docstring

- pyproject.toml: mark pyroscope-io as optional=true (proxy extra only)
- Add docs/my-website/docs/proxy/pyroscope_profiling.md (fix broken sidebar link)
- Add tests/test_litellm/proxy/test_pyroscope.py for _init_pyroscope()
- proxy_server: fix _init_pyroscope docstring (required server/app name, sample rate as int)

* Update litellm/proxy/proxy_server.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* fix(model_info): Add missing tpm/rpm for Gemini models (#21175)

Several Gemini models (TTS, native-audio, robotics, gemma) were missing
tpm/rpm values, causing test_get_model_info_gemini to fail.

Added conservative default values (tpm=250000, rpm=10) for preview models.
gemini-2.5-flash-preview-tts gets tpm=4000000, rpm=10.

Co-authored-by: OpenClaw <openclaw@users.noreply.github.com>

* fix(ci): Fix ruff lint error - unused import in vertex_ai_ingestion (#21178)

Co-authored-by: shin-bot-litellm <shin-bot-litellm@users.noreply.github.com>

* fix(ci): Fix mypy type errors across 6 files (#21179)

- vertex_ai/gemini: fix TypedDict assignment via explicit dict cast
- mcp_server: convert MutableMapping scope to dict for type safety
- pass_through_endpoints: simplify custom_body logic to fix type narrowing
- vector_store_endpoints: add Any annotation for dynamic hook return
- responses transformation: use dict() for Reasoning and setattr for dynamic field
- zscaler_ai_guard: add assert for api_base None check

Co-authored-by: shin-bot-litellm <shin-bot-litellm@users.noreply.github.com>

* fix(ci): Fix E2E login button selector - use exact match (#21176)

* fix(ci): Fix ruff lint error - unused import

Remove unused 'cast' import in vertex_ai_ingestion.py (ruff F401)

* fix(ci): Fix E2E login button selector - use exact match

Login button selector now matches both 'Login' and 'Login with SSO',
causing strict mode violation. Use { exact: true } to match only 'Login'.

---------

Co-authored-by: OpenClaw <openclaw@users.noreply.github.com>

* fix(mypy): Fix type errors across multiple files (#21180)

- vertex_ai/gemini/transformation.py: Fix TypedDict assignment via dict alias
- mcp_server/server.py: Convert ASGI scope to dict for type compatibility
- pass_through_endpoints.py: Add explicit Optional[dict] type annotation
- vector_store_endpoints/endpoints.py: Add Any type for dynamic proxy hook
- responses transformation.py: Use dict(Reasoning()) and setattr for compatibility
- zscaler_ai_guard.py: Add assert for api_base nullability

Co-authored-by: OpenClaw <openclaw@users.noreply.github.com>

* [Guardrails] Add guardrail pipeline support for conditional sequential execution (#21177)

* Add pipeline type definitions for guardrail pipelines

PipelineStep, GuardrailPipeline, PipelineStepResult, PipelineExecutionResult
with validation for actions (allow/block/next/modify_response) and modes.

* Export pipeline types from policy_engine types package

* Add optional pipeline field to Policy model

* Add pipeline executor for sequential guardrail execution

* Parse pipeline config in policy registry

* Add pipeline validation in policy validator

* Add pipeline resolution and managed guardrail tracking

* Resolve pipelines and exclude managed guardrails in pre-call

* Integrate pipeline execution into proxy pre_call_hook

* Add test guardrails for pipeline E2E testing

* Add example pipeline config YAML

* Add unit tests for pipeline type definitions

* Add unit tests for pipeline executor

* Update litellm/proxy/policy_engine/pipeline_executor.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update litellm/proxy/utils.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Add pipeline flow builder UI for guardrail policies (#21188)

* Add pipeline type definitions for guardrail pipelines

PipelineStep, GuardrailPipeline, PipelineStepResult, PipelineExecutionResult
with validation for actions (allow/block/next/modify_response) and modes.

* Export pipeline types from policy_engine types package

* Add optional pipeline field to Policy model

* Add pipeline executor for sequential guardrail execution

* Parse pipeline config in policy registry

* Add pipeline validation in policy validator

* Add pipeline resolution and managed guardrail tracking

* Resolve pipelines and exclude managed guardrails in pre-call

* Integrate pipeline execution into proxy pre_call_hook

* Add test guardrails for pipeline E2E testing

* Add example pipeline config YAML

* Add unit tests for pipeline type definitions

* Add unit tests for pipeline executor

* Add pipeline column to LiteLLM_PolicyTable schema

* Add pipeline field to policy CRUD request/response types

* Add pipeline support to policy DB CRUD operations

* Add PipelineStep and GuardrailPipeline TypeScript types

* Add Zapier-style pipeline flow builder UI component

* Integrate pipeline flow builder with mode toggle in policy form

* Add pipeline display section to policy info view

* Add unit tests for pipeline in policy CRUD types

* Refactor policy form to show mode picker first with icon cards

* Add full-screen FlowBuilderPage component for pipeline editing

* Wire up full-screen flow builder in PoliciesPanel with edit routing

* Restyle flow builder to match dev-tool UI aesthetic

* Restyle flow builder cards to match reference design

* Update step card to expanded layout with stacked ON PASS / ON FAIL sections

* Add end card to flow builder showing return to normal control flow

* Add PipelineTestRequest type for test-pipeline endpoint

* Export PipelineTestRequest from policy_engine types

* Add POST /policies/test-pipeline endpoint

* Add testPipelineCall networking function

* Add PipelineStepResult and PipelineTestResult types

* Add test pipeline panel to flow builder with run button and results display

* Fix pipeline executor: inject guardrail name into metadata so should_run_guardrail allows execution

* Update litellm/proxy/policy_engine/pipeline_executor.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update litellm/proxy/utils.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update litellm/proxy/policy_engine/policy_endpoints.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update litellm/proxy/policy_engine/pipeline_executor.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* fix(responses-bridge): extract list-format system content into instructions

When system message content is a list of content blocks
(e.g. [{"type": "text", "text": "..."}]) instead of a plain string,
the responses API bridge was passing it through as a role: system
message in the input items. APIs like ChatGPT Codex reject this
with "System messages are not allowed".

This happens when requests come through the Anthropic /v1/messages
adapter, which converts system prompts into list-format content blocks
in the OpenAI chat completions format.

Fix: extract text from list content blocks and concatenate into the
instructions parameter, matching the existing behavior for string
system content.

* test: add tests for system message extraction in responses bridge

Add three tests for convert_chat_completion_messages_to_responses_api:
- String system content → instructions
- List-format content blocks → instructions (the bug this PR fixes)
- Multiple system messages (mixed string and list) concatenated

* fix: add warning log for unexpected system content types

Address review feedback: add an else clause that logs a warning
for any system content that is neither str nor list, rather than
silently dropping it.

---------

Co-authored-by: yuneng-jiang <yuneng.jiang@gmail.com>
Co-authored-by: The Mavik <179817126+themavik@users.noreply.github.com>
Co-authored-by: themavik <themavik@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Ishaan Jaff <ishaanjaffer0324@gmail.com>
Co-authored-by: Alexsander Hamir <alexsanderhamirgomesbaptista@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: shin-bot-litellm <shin-bot-litellm@berri.ai>
Co-authored-by: OpenClaw <openclaw@users.noreply.github.com>
Co-authored-by: shin-bot-litellm <shin-bot-litellm@users.noreply.github.com>
sameetn pushed a commit to sameetn/litellm that referenced this pull request Feb 16, 2026
- vertex_ai/gemini/transformation.py: Fix TypedDict assignment via dict alias
- mcp_server/server.py: Convert ASGI scope to dict for type compatibility
- pass_through_endpoints.py: Add explicit Optional[dict] type annotation
- vector_store_endpoints/endpoints.py: Add Any type for dynamic proxy hook
- responses transformation.py: Use dict(Reasoning()) and setattr for compatibility
- zscaler_ai_guard.py: Add assert for api_base nullability

Co-authored-by: OpenClaw <openclaw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants