fix: address Greptile review feedback on PR #21018 - #21057
Merged
ishaan-jaff merged 1 commit intoFeb 12, 2026
Conversation
- Fix session time range calculation: use Math.min/Math.max across all entries instead of relying on array order (sessionLogs is sorted by type, not time). Other Greptile comments were already addressed in the branch: - LogDetailContent.tsx exists - Clipboard call already wrapped in try/catch - Dedup already uses O(1) Map lookup - model_dump() serialization is documented - GROUP BY performance comment already present
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
ishaan-jaff
merged commit Feb 12, 2026
79d4d7b
into
litellm_mcp_ui_logs_page_fixes
3 of 49 checks passed
Contributor
Greptile OverviewGreptile SummaryFixes an incorrect session time range calculation in
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/view_logs/LogDetailsDrawer/LogDetailsDrawer.tsx | Fixed session time range calculation to use Math.min/Math.max instead of array index access, since sessionLogs is sorted by call type (LLM vs MCP) first, not purely by time. |
ishaan-jaff
added a commit
that referenced
this pull request
Feb 12, 2026
…way (#21018) * commit new expansion * fix MCP * fix: LiteLLMProxyRequestSetup * _process_mcp_tools_without_openai_transform * UI fixes * UI refactor view logs/sessions * index * _add_mcp_tool_metadata_to_final_chunk * add badges * add getEventDisplayName * ui fixes * backend fix * fix * UI fix * UI fix * fix row * fix: address Greptile review feedback on PR #21018 (#21057) - Fix session time range calculation: use Math.min/Math.max across all entries instead of relying on array order (sessionLogs is sorted by type, not time). Other Greptile comments were already addressed in the branch: - LogDetailContent.tsx exists - Clipboard call already wrapped in try/catch - Dedup already uses O(1) Map lookup - model_dump() serialization is documented - GROUP BY performance comment already present --------- Co-authored-by: shin-bot-litellm <shin-bot-litellm@berri.ai>
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…way (BerriAI#21018) * commit new expansion * fix MCP * fix: LiteLLMProxyRequestSetup * _process_mcp_tools_without_openai_transform * UI fixes * UI refactor view logs/sessions * index * _add_mcp_tool_metadata_to_final_chunk * add badges * add getEventDisplayName * ui fixes * backend fix * fix * UI fix * UI fix * fix row * fix: address Greptile review feedback on PR BerriAI#21018 (BerriAI#21057) - Fix session time range calculation: use Math.min/Math.max across all entries instead of relying on array order (sessionLogs is sorted by type, not time). Other Greptile comments were already addressed in the branch: - LogDetailContent.tsx exists - Clipboard call already wrapped in try/catch - Dedup already uses O(1) Map lookup - model_dump() serialization is documented - GROUP BY performance comment already present --------- Co-authored-by: shin-bot-litellm <shin-bot-litellm@berri.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Greptile code review feedback from #21018.
Changes
Math.min/Math.maxacross allsessionLogsentries instead of[0]/[length-1](array is sorted by type, not time)Already addressed in the branch
The other 5 Greptile comments were already resolved:
LogDetailContent.tsxexistsmodel_dump()serialization documented