fix critical CVE vulnerabliltes

[Harshit28j]

Image vulnerabilities

Trivy scan result of image after fixes

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
litellm	Ready	Preview, Comment	Feb 8, 2026 0:55am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR addresses critical CVE vulnerabilities across npm and Python dependencies.

Key Changes:

• Pinned urllib3>=2.6.0, tornado>=6.5.3, and filelock>=3.20.1 in requirements.txt to fix multiple Python CVEs
• Added npm package overrides for tar>=7.5.7, glob>=11.1.0, and @isaacs/brace-expansion>=5.0.1 across all package.json files
• Implemented comprehensive Dockerfile security fixes that recursively replace vulnerable npm dependencies bundled inside npm itself and nodejs-wheel-binaries
• Updated .dockerignore pattern from node_modules/ to **/node_modules for better coverage
• Removed fixed CVEs from security scan allowlist in ci_cd/security_scans.sh

Critical Issue Found:
All Dockerfiles contain a logic error in the find commands for @isaacs/brace-expansion. The pattern -name "brace-expansion" searches for a directory named exactly "brace-expansion", but in npm's node_modules, scoped packages like @isaacs/brace-expansion are stored as @isaacs/brace-expansion/ where @isaacs is the parent directory. The current find commands will not match these directories, leaving the vulnerable versions in place.

Confidence Score: 2/5

• Critical logic errors will leave CVE vulnerabilities unpatched in production Docker images
• While the intent and approach are correct, the find command logic errors for @isaacs/brace-expansion in all 5 Dockerfiles mean the vulnerable brace-expansion packages won't be replaced. This defeats a major part of the security fix. The Python dependency pins and npm overrides are correctly implemented and will work.
• All Dockerfile variants (Dockerfile, docker/Dockerfile.database, docker/Dockerfile.dev, docker/Dockerfile.non_root, docker/Dockerfile.custom_ui) need the brace-expansion find logic corrected before merge

Important Files Changed

Filename	Overview
Dockerfile	Added comprehensive security fixes for npm dependencies by installing specific versions and recursively replacing bundled vulnerable packages in npm's internal dependency tree and nodejs-wheel-binaries
ci_cd/security_scans.sh	Removed CVE allowlist entries for tar, glob, and brace-expansion vulnerabilities that are now fixed; added CVE-2026-0775 for npm cli permission issue
docker/Dockerfile.custom_ui	Applied same npm security fixes as main Dockerfile - installs specific versions and replaces npm's internal bundled dependencies
docker/Dockerfile.database	Applied npm security fixes and added nodejs-wheel-binaries patching (removed previous nodejs-wheel node binary replacement)
docker/Dockerfile.dev	Applied npm security fixes and added nodejs-wheel-binaries patching for development Docker image
docker/Dockerfile.non_root	Applied npm security fixes and replaced nodejs-wheel node binary replacement with comprehensive dependency patching
requirements.txt	Added minimum version pins for urllib3, tornado, and filelock to address multiple CVEs

Sequence Diagram

sequenceDiagram
    participant Docker as Docker Build
    participant NPM as npm install
    participant Global as Global Packages
    participant Internal as npm Internal Deps
    participant Wheel as nodejs-wheel-binaries
    
    Docker->>NPM: Install npm@latest, tar@7.5.7, glob@11.1.0, @isaacs/brace-expansion@5.0.1
    NPM->>Global: Create global packages
    Note over NPM,Internal: Problem: npm has its own bundled versions
    Docker->>Global: Get global package path
    Docker->>Internal: find npm's internal tar/glob/brace-expansion
    Docker->>Internal: Replace with secure versions from global
    
    Docker->>Docker: pip install requirements (includes nodejs-wheel-binaries)
    Note over Wheel: nodejs-wheel-binaries bundles old npm with vulnerabilities
    Docker->>Wheel: find nodejs_wheel's tar/glob/brace-expansion
    Docker->>Wheel: Replace with secure versions from global

Loading

[greptile-apps]

_{7 files reviewed, 9 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

The search pattern -name "brace-expansion" won't match the scoped package directory structure. @isaacs is the parent directory containing brace-expansion.

Suggested change

	&& find "$GLOBAL/npm" -type d -name "brace-expansion" -path "*/node_modules/@isaacs/brace-expansion" | while read d; do \
	&& find "$GLOBAL/npm" -type d -name "@isaacs" -path "*/node_modules/@isaacs" | while read d; do \
	rm -rf "$d/brace-expansion" && cp -rL "$GLOBAL/@isaacs/brace-expansion" "$d/brace-expansion"; \

[Harshit28j]

you're assuming that the parent is @isaacs, we must search for @isaacs.
That’s unnecessary.
we’re here looking for directories named brace-expansion under .../node_modules/@isaacs/brace-expansion, and -name "brace-expansion" does exactly that.
same for all patterns

[Harshit28j]

i build image in my local and its working

[greptile-apps]

You're correct. The -name "brace-expansion" pattern will match the directory named brace-expansion regardless of its parent directory structure. The -path "*/node_modules/@isaacs/brace-expansion" constraint ensures we're only finding it in the right location.

All three find patterns are correct:

• -name "tar" -path "*/node_modules/tar" matches tar directories
• -name "glob" -path "*/node_modules/glob" matches glob directories
• -name "brace-expansion" -path "*/node_modules/@isaacs/brace-expansion" matches brace-expansion directories under the @isaacs scope

My previous comment was incorrect - the scoped package structure doesn't require searching for the parent directory.

[isaacs]

you're assuming that the parent is @isaacs, we must search for @isaacs. That’s unnecessary.

I agree. And yet, you found me, unnecessarily. 😅

[Harshit28j]

Ah my bad for accidental mention I was talking about package 🙂
thanks for the good work you have done for the community tho :)

[isaacs]

Don't sweat it one bit, my inbox has been a trash fire since 2012, I just happened to be looking when this passed by. Keep on making stuff, love to see it :)

[fedorum]

Image vulnerabilities

## Trivy scan result of image after **fixes**

Hi. Not entirely sure if this is the right place to ask, but do these fixes also fix the following vulnerabilities?

• CVE-2025-55130
• CVE-2025-15467

I would think that they are separate and would need to be patched individually. Thanks for any reply!