Revert "fix: proxy failure cases, now log ip and user agent, key hash, name" - #20413
Merged
Sameerlite merged 1 commit intoFeb 4, 2026
Merged
Conversation
…, name (…" This reverts commit ec279eb.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sameerlite
merged commit Feb 4, 2026
674593e
into
litellm_oss_staging_02_03_2026
2 of 3 checks passed
Contributor
Greptile OverviewGreptile SummaryThis PR reverts changes from #20145 that were causing database-related test failures. The revert restores the previous behavior across authentication, logging, and metrics collection. Key changes being reverted:
Behavior implications: The revert trades off observability improvements (detailed auth failure logging) for test stability. After this revert:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| litellm/integrations/prometheus.py | Reverts behavior to skip 401 auth errors from metrics instead of tracking all requests |
| litellm/proxy/auth/auth_checks.py | Changes HTTP 400 to 401 for model access denied errors (team/user/org/vector store access) |
| litellm/proxy/auth/auth_exception_handler.py | Removes client context (IP, user-agent, key hash, key name) from auth error logging |
Sequence Diagram
sequenceDiagram
participant Client
participant ProxyAPI
participant AuthModule
participant LoggingModule
participant MetricsModule
Client->>ProxyAPI: HTTP Request
ProxyAPI->>AuthModule: Authenticate request
alt Valid Authentication
AuthModule-->>ProxyAPI: Return UserAPIKeyAuth
ProxyAPI->>Client: Process request
else Invalid Authentication
AuthModule->>LoggingModule: Log error
Note over LoggingModule: Simplified context logging
LoggingModule->>MetricsModule: Record failure
alt HTTP 401
Note over MetricsModule: REVERT: Skip from metrics
MetricsModule->>MetricsModule: Skip recording
else HTTP 400
Note over MetricsModule: Record in Prometheus
MetricsModule->>MetricsModule: Record metrics
end
AuthModule-->>ProxyAPI: Raise exception
ProxyAPI->>Client: Error response
end
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…failure_cases Revert "fix: proxy failure cases, now log ip and user agent, key hash, name"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20145
All db related tests started failing after this: https://app.circleci.com/pipelines/github/BerriAI/litellm/57025/details