Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR reverts three previous features and fixes test failures in the MCP semantic tool filter tests. Reverted Changes:
Test Fixes:
Documentation:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| litellm/proxy/auth/model_checks.py | Removed get_access_groups_from_models function and minor formatting changes |
| litellm/proxy/litellm_pre_call_utils.py | Removed access group extraction logic for router filtering (reverted) |
| litellm/router.py | Removed access group filtering from router deployment selection (reverted) |
| litellm/router_utils/common_utils.py | Removed filter_deployments_by_access_groups function and minor formatting |
| litellm/router_utils/fallback_event_handlers.py | Removed fallback list exhaustion check from fallback handler (reverted) |
| schema.prisma | Removed VerificationToken table indexes from schema (reverted) |
Sequence Diagram
sequenceDiagram
participant Client
participant ProxyServer as Proxy Server
participant PreCallUtils as litellm_pre_call_utils
participant Router
participant Fallback as Fallback Handler
participant LLM
Note over ProxyServer,Router: REVERTED: Access Group Filtering
Client->>ProxyServer: Request with API Key
ProxyServer->>PreCallUtils: add_litellm_data_to_request()
Note over PreCallUtils: ❌ REMOVED: Extract access groups<br/>from key/team models
PreCallUtils->>Router: Request without access group metadata
Note over Router: ❌ REMOVED: filter_deployments_by_access_groups()
Router->>Router: Select deployment (no access group filtering)
Router->>LLM: Forward request
alt Request Fails
LLM-->>Router: Error
Router->>Fallback: run_async_fallback()
Note over Fallback: ❌ REMOVED: Check if fallback list exhausted<br/>(fallback_depth >= fallback_group_length)
Note over Fallback: ✅ KEPT: Only check max_fallbacks limit
Fallback->>Router: Try next fallback model
Router->>LLM: Retry with fallback
LLM-->>Client: Response
end
Note over ProxyServer,Router: REVERTED: Database Indexes
Note over ProxyServer: ❌ REMOVED: Prisma indexes on<br/>VerificationToken table<br/>(user_id, team_id, budget_reset_at, expires)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes