litellm_fix: add migration for vector store team_id/user_id columns#20193
Closed
shin-bot-litellm wants to merge 1 commit intomainfrom
Closed
litellm_fix: add migration for vector store team_id/user_id columns#20193shin-bot-litellm wants to merge 1 commit intomainfrom
shin-bot-litellm wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds the missing database migration file for
The migration follows the standard Prisma migration format and aligns with the schema changes. This resolves the CI test failure in Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| litellm-proxy-extras/litellm_proxy_extras/migrations/20260131_add_team_user_to_vector_stores/migration.sql | Adds team_id and user_id TEXT columns to LiteLLM_ManagedVectorStoresTable with indexes on both columns |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant PR as PR #19972
participant Schema as schema.prisma
participant DB as Database
participant Migration as Migration Script
participant CI as CI Tests
Note over Dev,PR: Original PR #19972
Dev->>Schema: Add team_id and user_id fields
Dev->>Schema: Add indexes on team_id and user_id
PR->>CI: Run tests (missing migration)
CI-->>PR: ❌ test_aaaasschema_migration_check fails
Note over Dev,Migration: This PR (Fix)
Dev->>Migration: Generate migration.sql
Migration->>DB: ALTER TABLE ADD COLUMN team_id TEXT
Migration->>DB: ALTER TABLE ADD COLUMN user_id TEXT
Migration->>DB: CREATE INDEX on team_id
Migration->>DB: CREATE INDEX on user_id
DB-->>Migration: ✓ Schema synchronized
Migration->>CI: Run schema migration check
CI-->>Migration: ✓ Tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in
test_aaaasschema_migration_check.Problem
PR #19972 (commit 9c5fed4) added
team_idanduser_idcolumns toLiteLLM_ManagedVectorStoresTableinschema.prismabut did not include the corresponding migration file.Solution
Add the missing migration file with:
team_idTEXT columnuser_idTEXT columnRegression
9c5fed4
Testing
This migration was generated by
prisma migrate diffbased on the schema changes.