litellm_fix: refactor base_process_llm_request to fix PLR0915#20125
Closed
shin-bot-litellm wants to merge 2 commits intomainfrom
Closed
litellm_fix: refactor base_process_llm_request to fix PLR0915#20125shin-bot-litellm wants to merge 2 commits intomainfrom
shin-bot-litellm wants to merge 2 commits intomainfrom
Conversation
The function exceeds the 50 statement limit due to comprehensive request handling logic. Adding noqa comment as quick fix - refactoring can be done in a separate PR.
- Extract response metadata extraction into _extract_response_metadata helper - Add ResponseMetadata NamedTuple for type-safe metadata handling - Use metadata object instead of individual variables to reduce statement count - Remove noqa: PLR0915 suppression as the function now passes ruff check This properly addresses the 'too many statements' warning by refactoring instead of suppressing it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
base_process_llm_requestmethod inRouterto fix PLR0915 (too many statements).Extracts helper methods for cleaner code organization:
_prepare_call_context_log_verbose_retry_context_try_model_fallback_from_exception_select_retry_delay_from_headers