Skip to content

Fix test_mcp_server_manager_config_integration_with_database cancellation error #19801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexsanderHamir merged 1 commit into from
Jan 26, 2026
Merged

Fix test_mcp_server_manager_config_integration_with_database cancellation error #19801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/mcp_tests/test_mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,9 +1105,16 @@ async def mock_get_allowed_servers(user_auth=None):

test_manager.get_allowed_mcp_servers = mock_get_allowed_servers

# Test the method (this tests our second fix)
import asyncio
# Mock _create_mcp_client to return a client that completes immediately
# This avoids network calls while preserving the actual conversion logic
def mock_create_mcp_client(*args, **kwargs):
mock_client = MagicMock()
mock_client.run_with_session = AsyncMock(return_value="ok")
return mock_client

test_manager._create_mcp_client = mock_create_mcp_client

# Test the method (this tests our second fix)
servers_list = await test_manager.get_all_mcp_servers_with_health_and_teams(
user_api_key_auth=mock_user_auth
)
Expand Down
Loading