Skip to content

fix(image_edit): add drop_params support and fix Vertex AI config#18077

Merged
krrishdholakia merged 1 commit intoBerriAI:litellm_staging_12_17_2025from
castrapel:fix/image-edit-drop-params-vertex-config
Dec 17, 2025
Merged

fix(image_edit): add drop_params support and fix Vertex AI config#18077
krrishdholakia merged 1 commit intoBerriAI:litellm_staging_12_17_2025from
castrapel:fix/image-edit-drop-params-vertex-config

Conversation

@castrapel
Copy link
Contributor

Relevant issues

Solves three related issues in the image edit API for Vertex AI (including #17719 ):

  1. drop_params not respected - The image edit API was not honoring litellm.drop_params or the explicit drop_params parameter, this led to UnsupportedParamsError even when users configured silent dropping of unsupported parameters.
  2. vertex_project/vertex_location not read from litellm_params - The Vertex AI Gemini image edit config was not checking litellm_params for project/location values, only falling back to environment variables.
  3. Incorrect URL for vertex_location: "global" - When using the global location, the URL was incorrectly created as https://global-aiplatform.googleapis.com instead of https://aiplatform.googleapis.com.

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • My PR passes all unit tests on make test-unit
    973 passed, 4 failed (pre-existing upstream failures unrelated to this PR, some appear to be due to my lack of AWS credentials)
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

CI (LiteLLM team)

CI status guideline:

  • 50-55 passing tests: main is stable with minor issues.
  • 45-49 passing tests: acceptable but needs attention
  • <= 40 passing tests: unstable; be careful with your merges and assess the risk.
  • Branch creation CI run
    Link:

  • CI run for the last commit
    Link:

  • Merge / cherry-pick CI run
    Links:

Type

🐛 Bug Fix

Changes

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
litellm Ready Ready Preview, Comment Dec 16, 2025 9:31pm

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2025

CLA assistant check
All committers have signed the CLA.

@krrishdholakia krrishdholakia changed the base branch from main to litellm_staging_12_17_2025 December 17, 2025 05:58
@krrishdholakia krrishdholakia merged commit d1c6eb3 into BerriAI:litellm_staging_12_17_2025 Dec 17, 2025
6 of 7 checks passed
@castrapel castrapel deleted the fix/image-edit-drop-params-vertex-config branch December 17, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants