Fix get_model_from_request() to extract model ID from Vertex AI passthrough URLs#17970
Merged
1 commit merged intoBerriAI:litellm_staging_12_16_2025from Dec 16, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
da27392 to
02a5585
Compare
extract model id from vertex ai passthrough routes that follow the pattern:
/vertex_ai/*/models/{model_id}:*
the model extraction now handles vertex ai routes by regex matching the model
segment from the url path, which allows proper model identification for
authentication and authorization in proxy pass-through endpoints.
adds comprehensive test coverage for vertex ai model extraction including:
- various vertex api versions (v1, v1beta1)
- different locations (us-central1, asia-southeast1)
- model names with special suffixes (gemini-1.5-pro, gemini-2.0-flash)
- precedence verification (request body model over url)
- non-vertex route isolation
02a5585 to
4fd62a2
Compare
ae7c994
into
BerriAI:litellm_staging_12_16_2025
6 of 7 checks passed
Contributor
|
@krisxia0506 Reverted this PR. Can you make sure your tests pass. All o them are failing |
Contributor
Author
I have run both test files in this PR successfully and attached screenshots in the PR description. Could you please let me know which tests did not pass and specify them clearly? |
Contributor
Contributor
Author
|
Thank you sir, I accidentally integrated another method from a PR #17526 that hasn't been merged yet into my unit test method |
Contributor
Author
|
@Sameerlite Hello, sir, I have resubmitted my changes in a new PR #18097. Please help me review them. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Title
Fix get_model_from_request() to extract model ID from Vertex AI passthrough URLs
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Summary
This PR enhances the model extraction logic in the proxy authentication module to properly handle Vertex AI passthrough routes. Previously, the
get_model_from_request()function could not extract model IDs from Vertex AI passthrough URLs, which follows a distinct pattern compared to OpenAI deployments.Problem
Vertex AI passthrough endpoints have a URL structure like:
The existing model extraction logic only handled OpenAI deployments (
/openai/deployments/{model}/), leaving Vertex AI models unidentified.Solution
Added regex-based model extraction for Vertex AI routes:
/vertex_ai/.../models/{model_id}:*/models/([^/:]+)Testing
Added comprehensive test coverage with 7 parametrized test cases in
test_get_model_from_request_vertex_ai_passthrough():Files Changed
litellm/proxy/auth/auth_utils.py: Added Vertex AI model extraction logictests/local_testing/test_auth_utils.py: Added parametrized test casestests/test_litellm/proxy/pass_through_endpoints/test_vertex_passthrough_auth.py: New test file with additional Vertex AI passthrough tests