Skip to content

vertex ai: use the correct domain for the global location when counti… - #17120

Closed
CAFxX wants to merge 2 commits into
BerriAI:mainfrom
CAFxX:cafxx-fix-tokencount-vertex-global
Closed

vertex ai: use the correct domain for the global location when counti…#17120
CAFxX wants to merge 2 commits into
BerriAI:mainfrom
CAFxX:cafxx-fix-tokencount-vertex-global

Conversation

@CAFxX

@CAFxX CAFxX commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Title

Fix a unit test (sorry for the churn, in the previous PR I mistakenly pushed the wrong git ref)

Relevant issues

Followup to #17116

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
✅ Test

Changes

Screenshot 2025-11-26 at 12 54 21

@vercel

vercel Bot commented Nov 26, 2025

Copy link
Copy Markdown

@CAFxX is attempting to deploy a commit to the CLERKIEAI Team on Vercel.

A member of the Team first needs to authorize it.

@CAFxX
CAFxX marked this pull request as draft November 26, 2025 03:58
@CAFxX
CAFxX force-pushed the cafxx-fix-tokencount-vertex-global branch from 03a91a9 to f93b7e2 Compare November 26, 2025 03:59
@CAFxX
CAFxX marked this pull request as ready for review November 26, 2025 04:00
@CAFxX
CAFxX force-pushed the cafxx-fix-tokencount-vertex-global branch from f93b7e2 to 5b66633 Compare November 26, 2025 04:02
@CAFxX

CAFxX commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

Bump up. This is just a followup fix for a test I submitted earlier.

@CAFxX

CAFxX commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

@krrishdholakia bump up this is just a small fix to a test

@vercel

vercel Bot commented Dec 10, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Dec 10, 2025 3:58am

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions Bot added the stale label Mar 11, 2026
@github-actions github-actions Bot closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant