fix: Add response_type + PKCE parameters to OAuth authorization endpoint - #15720
Merged
2 commits merged intoOct 21, 2025
Merged
Conversation
|
Someone is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Fixes BerriAI#15684 OAuth providers like Google require the response_type parameter during the authorization flow. This commit adds response_type=code to the authorization redirect parameters, which is required by the OAuth 2.0 specification (RFC 6749 Section 4.1.1). Changes: - Added response_type=code to authorization params in discoverable_endpoints.py - Added test coverage for the response_type parameter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
talalryz
force-pushed
the
fix/add-response-type-oauth
branch
from
October 21, 2025 01:35
09290d3 to
2e282de
Compare
talalryz
changed the title
Contributor
Author
|
cc: @mubashir1osmani @krrishdholakia @ishaan-jaff please take a look |
|
LGTM! Thank you for the fix @talalryz |
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…int (BerriAI#15720) * fix: Add response_type parameter to OAuth authorization endpoint Fixes BerriAI#15684 OAuth providers like Google require the response_type parameter during the authorization flow. This commit adds response_type=code to the authorization redirect parameters, which is required by the OAuth 2.0 specification (RFC 6749 Section 4.1.1). Changes: - Added response_type=code to authorization params in discoverable_endpoints.py - Added test coverage for the response_type parameter * fix oauth flow by forwarding code_challenge and forwarding code_verifier ---------
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do
Fixes OAuth 2.1 PKCE (Proof Key for Code Exchange) support in LiteLLM's MCP OAuth proxy.
Previously, the proxy did not forward PKCE parameters, causing OAuth flows with providers like
Google to fail when used with PKCE-compliant clients (such as Claude Code).
Changes Made
Authorization endpoint (
/authorize):code_challengeandcode_challenge_methodquery parametersToken endpoint (
/token):code_verifierform parameterState management:
Tests:
test_authorize_endpoint_forwards_pkce_parameters()to verify PKCE parameter forwardingin authorization
test_token_endpoint_forwards_code_verifier()to verify PKCE verifier forwarding intoken exchange
Impact
🤖 Generated with Claude Code
Relevant issues
Fixes #15684
Tested Locally -> screenshots
Step 1
Step 2
Step 3
Pre-Submission checklist
tests/litellm/directory, Addingat least 1 test is a hard requirement - see
details
make test-unitType
🐛 Bug Fix