Repository navigation
Langsmith: Add envs for project/run names; fix bug with None metadata - #1524
Merged
ishaan-jaff merged 4 commits intoJan 19, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
approved these changes
Jan 19, 2024
| run_name = metadata.get("run_name", "LLMRun") | ||
| # if not set litellm will fallback to the environment variable LANGSMITH_PROJECT, then to the default project_name = litellm-completion, run_name = LLMRun | ||
| project_name = metadata.get("project_name", self.langsmith_project) | ||
| run_name = metadata.get("run_name", self.langsmith_default_run_name) |
Contributor
|
@timothyasp thanks for the contribution ! |
Merged
7 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off - thanks for your work on this project! Been loving working with this since migrating from langchain.
--
Ran into a problem with a fresh install and trying to integrate with an existing langsmith project, if there was no
metadataset on the completion, the request would silently fail when logging to langsmith.I also added project envs for setting new project names as it's a pain to have to add metadata to every completion call.