Skip to content

Conversation

sashank5644
Copy link
Contributor

Title

Create team models reset bug fix

https://www.loom.com/share/a0056f963ea946d8861e0cfb710d59be?sid=550aa1f8-4835-4318-962e-34f2eb8b2529

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring
✅ Test

Changes

Refactored useEffect logic for handling model selection section auto reset, and added comprehensive testing to test_teams.py and redid some prior bug issues in test suite.

Copy link

vercel bot commented Sep 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Sep 13, 2025 1:33am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your change is a ui change - i'm confused why add the the tests on the backend api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I made edits tot he useEffect callback on the frontend, I needed to add tests to ensure the server properly stores and receives models when teams are created, this will then make sure that my change in the frontend doesn't break any functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants