-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Fix - using managed files w/ OTEL + UI - add model group alias on UI #13171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1a9f6f6
fix(router.py): safe deep copy kwargs
919fb5b
fix: use safe deep copy in other places as well
80348a5
test: add script to check and ban copy.deepcopy of kwargs
07eeae9
build(ui/): new component for adding model group alias on UI
f5ae087
fix(proxy_server.py): support updating model_group_alias via /config/…
c00dcda
fix(router.py): update model_group_alias in router settings based on …
4a9b11b
fix: fix code qa error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| model_list: | ||
| - model_name: genai/test/* | ||
| - model_name: "gpt-4o-mini-openai" | ||
| litellm_params: | ||
| model: openai/* | ||
| api_base: https://api.openai.com | ||
| model: gpt-4o-mini | ||
| api_key: os.environ/OPENAI_API_KEY | ||
|
|
||
| litellm_settings: | ||
| check_provider_endpoint: true | ||
| router_settings: | ||
| model_group_alias: {"gpt-4o": "gpt-4o-mini-openai"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Deep Copy Fails Span Handling, Data Integrity
The
safe_deep_copyfunction contains two logic errors:litellm_parent_otel_spanexists in bothmetadataandlitellm_metadatadictionaries, the single variable used to temporarily store the span is overwritten. This causes the first span to be lost, and the second span is then incorrectly restored to both locations in the original data object, leading to potential incorrect OTEL tracing behavior.dataobject, while returningnew_datawhich still contains these "placeholder" strings. This results in the returned deep copy being incomplete and potentially unusable for consumers expecting valid span objects.Locations (1)
litellm/litellm_core_utils/core_helpers.py#L220-L250