[Bedrock] Fixes to only allow accepted fields for tool json schema - #10062
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
added a commit
that referenced
this pull request
May 14, 2025
…10062) * add test_function_calling_with_tool_response to base llm tests * run test suite for nova * update test_function_calling_with_tool_response * allowed ToolJsonSchemaBlock keys * fix ToolJsonSchemaBlock * add back pytest fixture * test: test_prompt_caching
4 tasks
This was referenced Jun 5, 2026
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…erriAI#10062) * add test_function_calling_with_tool_response to base llm tests * run test suite for nova * update test_function_calling_with_tool_response * allowed ToolJsonSchemaBlock keys * fix ToolJsonSchemaBlock * add back pytest fixture * test: test_prompt_caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bedrock] Fixes to only allow accepted fields for tool json schema
This PR addresses the issue with Bedrock tool input schema formatting. Previously, we were sending the entire JSON schema object directly, which could include non-standard keys like $id and $schema that are not supported in the Bedrock API's expected format.
Changes
Testing
Confirmed this works for:
Bedrock Converse Nova + Anthropic model family
Bedrock Invoke Nova + Anthropic model family
OpenAI models
Added a specific test case that verifies the tool schema transformation removes unsupported JSON schema fields
Added passing $id and $schema in our base llm tool calling test suite, this will now test all our providers and make sure this request works
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Type
🐛 Bug Fix
✅ Test
Changes