docs(proxy): the --pkce refresh token now lives in the OS keychain - #967
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
7 tasks
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f197b2d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI docs still said the
--pkcerefresh token sits in~/.litellm/token.json, and told readers to treat that file as sensitive because anyone who can read it can trade the refresh token for a working key. PR #37665 moves the refresh token into the OS keychain next to the key, so that stops being true on any machine with a keychainThe security warning now applies to the case where it still holds, a machine with no usable keychain, where both halves fall back into the
0600file andlite loginsays so. The stored-credential section also picks up the upgrade note: a--pkcelogin made with an earlierlitekeeps its refresh token in the file until the next command reads it and moves it.lite logoutis described as clearing both stores rather than just deleting the file, which has been true since the key moved into the keychainMerge alongside BerriAI/litellm#37665
Note
Low Risk
Documentation-only wording updates; no code, auth, or storage behavior is changed in this PR.
Overview
Updates CLI docs so
--pkcestorage matches the keychain change: the refresh token now lives in the OS keychain next to the key, not in~/.litellm/token.json.The sensitivity warning is limited to machines with no usable keychain (both secrets fall back into that
0600file). Docs also note that older--pkcelogins keep the refresh token in the file until the nextlitecommand migrates it, and thatlite logoutclears both the keychain and the token file.Reviewed by Cursor Bugbot for commit f197b2d. Bugbot is set up for automated code reviews on this repo. Configure here.