Skip to content

docs(langfuse): correct metadata and update_trace_keys behavior - #902

Merged
yucheng-berri merged 1 commit into
mainfrom
litellm_langfuse_docs_slp_behavior
Aug 15, 2026
Merged

docs(langfuse): correct metadata and update_trace_keys behavior#902
yucheng-berri merged 1 commit into
mainfrom
litellm_langfuse_docs_slp_behavior

Conversation

@yucheng-berri

@yucheng-berri yucheng-berri commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Four statements on the Langfuse page no longer match the code, all live-verified against staging head 0f2566e823.

update_trace_keys is gated behind langfuse_enable_update_trace_keys (default off) by BerriAI/litellm#36862, so the inline comment in the example and the masking paragraph both needed the condition. Driven live: with the flag off the continuation writes nothing, with it on input, output and trace metadata all apply.

Arbitrary metadata no longer lands flat on the generation since BerriAI/litellm#36744; it arrives under requester_metadata. Proxy callers get this automatically. SDK callers need to nest, which the added snippet shows. Verified through the real payload builder: flat gives requester_metadata=null, nested preserves the dict including nesting.

debug_langfuse is filtered to scalars rather than the exact metadata, since the raw dump previously carried the resolved auth object.

Not covered here, both predate these changes: trace_user_id does not actually default to the user argument on the SDK path, and the Python snippets at lines 117 and 277 have missing commas and will not compile.


Open in Devin Review

@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview Aug 15, 2026 6:25pm

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@yucheng-berri
yucheng-berri merged commit 6dc177b into main Aug 15, 2026
3 checks passed
@yucheng-berri
yucheng-berri deleted the litellm_langfuse_docs_slp_behavior branch August 15, 2026 18:28
@snozwoz

snozwoz commented Aug 17, 2026

Copy link
Copy Markdown

Ive got this same issue, sometimes llm calls are logged in LangGraph v4.11, sometimes not, and when they are, we see metadata but not input and output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants