Skip to content

docs(bedrock): s3_encryption_key_id also encrypts the batch input upload - #810

Merged
mateo-berri merged 3 commits into
mainfrom
litellm_bedrock_batch_sse_kms_docs
Aug 7, 2026
Merged

docs(bedrock): s3_encryption_key_id also encrypts the batch input upload#810
mateo-berri merged 3 commits into
mainfrom
litellm_bedrock_batch_sse_kms_docs

Conversation

@mateo-berri

@mateo-berri mateo-berri commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

s3_encryption_key_id is documented as covering the batch output only. BerriAI/litellm#35148 makes LiteLLM sign the batch input-file upload with the same key, which is what unblocks KMS-enforced buckets, so the docs need to say the key now covers both objects.

The practical consequence for anyone who already set the key for outputs: the identity LiteLLM uploads with now needs kms:GenerateDataKey on it, or POST /v1/files starts returning an S3 AccessDenied. That warning is the main thing this PR adds, alongside the reworded parameter table row and config comment.

Verified live against a bucket whose policy denies PutObject unless the object carries that exact key ARN: the upload 403s on litellm_internal_staging and returns a file id on the fix branch, with head-object reporting ServerSideEncryption: aws:kms and the configured SSEKMSKeyId


Note

Low Risk
Documentation-only changes to Bedrock batch KMS guidance; no runtime or security logic modified in this PR.

Overview
Updates Bedrock batch docs so s3_encryption_key_id is described as applying to both the batch input file LiteLLM uploads to S3 and the batch output—not output only.

The optional-parameter table, sample config comment, and KMS FAQ are reworded to match behavior from BerriAI/litellm#35148. The FAQ adds that uploads use aws:kms with that key ARN, so the uploader needs kms:GenerateDataKey on the key or POST /v1/files can fail with S3 AccessDenied.

Reviewed by Cursor Bugbot for commit 15ff311. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview Aug 7, 2026 3:22am

Request Review

@mateo-berri

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 15ff311. Configure here.

@mateo-berri
mateo-berri merged commit 072d6f7 into main Aug 7, 2026
3 checks passed
@mateo-berri
mateo-berri deleted the litellm_bedrock_batch_sse_kms_docs branch August 7, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant