docs(bedrock): s3_encryption_key_id also encrypts the batch input upload - #810
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
10 tasks
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 15ff311. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s3_encryption_key_idis documented as covering the batch output only. BerriAI/litellm#35148 makes LiteLLM sign the batch input-file upload with the same key, which is what unblocks KMS-enforced buckets, so the docs need to say the key now covers both objects.The practical consequence for anyone who already set the key for outputs: the identity LiteLLM uploads with now needs
kms:GenerateDataKeyon it, orPOST /v1/filesstarts returning an S3AccessDenied. That warning is the main thing this PR adds, alongside the reworded parameter table row and config comment.Verified live against a bucket whose policy denies
PutObjectunless the object carries that exact key ARN: the upload 403s onlitellm_internal_stagingand returns a file id on the fix branch, withhead-objectreportingServerSideEncryption: aws:kmsand the configuredSSEKMSKeyIdNote
Low Risk
Documentation-only changes to Bedrock batch KMS guidance; no runtime or security logic modified in this PR.
Overview
Updates Bedrock batch docs so
s3_encryption_key_idis described as applying to both the batch input file LiteLLM uploads to S3 and the batch output—not output only.The optional-parameter table, sample config comment, and KMS FAQ are reworded to match behavior from BerriAI/litellm#35148. The FAQ adds that uploads use
aws:kmswith that key ARN, so the uploader needskms:GenerateDataKeyon the key orPOST /v1/filescan fail with S3AccessDenied.Reviewed by Cursor Bugbot for commit 15ff311. Bugbot is set up for automated code reviews on this repo. Configure here.