docs(sagemaker): distinguish native sagemaker_chat streaming from legacy fake streaming - #637
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
docs(sagemaker): distinguish native sagemaker_chat streaming from legacy fake streaming#637devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…acy fake streaming Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SageMaker page said flatly that "Sagemaker currently does not support streaming", which is stale for the
sagemaker_chat/route. That statement is only true for the legacysagemaker/completion route (which hits/invocationsand fakes streaming by chunking the full string);sagemaker_chat/hits/invocations-response-streamand streams natively.Two edits to
docs/providers/aws_sagemaker.md:sagemaker/route and points readers to the Messages API section for native streamingsagemaker_chat/streams natively, forwards each decoded event as it arrives (so TTFT and chunk cadence track the endpoint), and thatstream=Trueputs"stream": truein the signed request bodyCompanion to the code fix in BerriAI/litellm#34338 (LIT-4313), which removed the fixed 1024-byte read buffer that was inflating client TTFT on
sagemaker_chatstreams.Link to Devin session: https://app.devin.ai/sessions/27eec2ce9b6a4f6db8a8fbc96dd95e39
Requested by: @shivamrawat1