Repository navigation
docs(mcp): pin holds the raw upstream text and overrides apply on top of it - #1792
Open
mateo-berri wants to merge 1 commit into
Open
mateo-berri wants to merge 1 commit into
mateo-berri wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d299d33. Configure here.
4 of 7 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Follow-up to #1750: the pin now snapshots the upstream tool text as the server reports it, before any
tool_name_to_descriptionoverride or guardrail masking, and overrides apply on top of the pin at every listing. This keeps the docs in step with that changeWhat changed
docs/mcp_control.md: the pin section says what the snapshot holds (raw upstream text, minus tools a guardrail blocks at pin time), that overrides and masking apply on top of the pin, that editing an override never reads as drift while an upstream change is still reported even when an override hides it, and that a call to a tool outside the pin is refused inside the MCP result withisError: true, which is what a client sees over/mcpCompanion PR
The behavior change lands in BerriAI/litellm; this PR merges once that one does. BerriAI/litellm#43283
Note
Low Risk
Documentation-only updates to MCP pin semantics; no runtime or configuration behavior changes in this repo.
Overview
Updates
docs/mcp_control.mdso MCP pin behavior matches the companion LiteLLM change: the stored snapshot is raw upstream tool text (beforetool_name_to_descriptionand guardrail masking), while overrides and masking are applied on each listing on top of the pin.The doc also clarifies that calls to tools outside the pinned catalog are refused in the MCP result with
isError: true(not a bare HTTP403), that guardrails run on pinned text with overrides applied, and that editing an override does not count as drift while upstream description changes still trigger change alerts even when an override hides them from clients.Reviewed by Cursor Bugbot for commit d299d33. Bugbot is set up for automated code reviews on this repo. Configure here.