Repository navigation
docs(proxy): keep the heuristic_v2_router_limit row until the Router kwarg rename lands - #1180
Merged
Conversation
…kwarg rename lands
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7b9f609. Configure here.
mateo-berri
deleted the
litellm_docs_keep_heuristic_v2_router_limit_row
branch
September 4, 2026 01:15
6 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
#1179 renamed the router_settings row to auto_router_capability_limit ahead of BerriAI/litellm#39674, so every litellm PR now fails the required documentation and code-quality checks with Keys not documented in 'router settings - Reference': {'heuristic_v2_router_limit'}. This adds the current name back as its own row, next to the new one, so both names pass tests/documentation_tests/test_router_settings.py until the code rename merges, at which point the row can go
Proof
Failing run on an unrelated PR: https://github.com/BerriAI/litellm/actions/runs/33823853971/job/100872171991
The test only requires every Router.init kwarg to appear in the table, so an extra documented key is harmless
Note
Low Risk
Documentation-only change to the proxy config reference table; no runtime or routing behavior is modified.
Overview
Restores a
router_settingsreference row forheuristic_v2_router_limitindocs/proxy/config_settings.md, placed next toauto_router_capability_limit.The new row explains that
heuristic_v2_router_limitis still the liveRouter.__init__kwarg name until litellm#39674 lands, and that it matches the same SDK-only callable ceiling onclassifier_type: heuristic_v2routers.This unblocks
test_router_settings(every Router kwarg must appear in the table) after the docs were ahead of the code rename; the extra documented key is harmless until the old row can be removed post-merge.Reviewed by Cursor Bugbot for commit 7b9f609. Bugbot is set up for automated code reviews on this repo. Configure here.