Repository navigation
feat(signals): accept the decisions model mode alongside evaluation - #67
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
kerry-berri
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiteLLM is adding cost map rows for decision models with
mode: decisions. The existing rows keep the legacymode: evaluation(BerriAI/litellm#45474 makes the gateway accept both). Lens only matchedevaluation, so adecisionsmodel was never discovered for Signals, and saving a Signals config with one was rejectedThis PR treats both values the same through one predicate,
lens_contract::activity::is_decisions_mode, used in gateway discovery (gateway/discovery.rs) and the Signals save check (server/src/signals.rs). The UI filtersystemOneModelsuses a matchingisDecisionsMode, anddocs/signals.mdnames both modesTests
discovery.rshas a new test that discovers adecisionsmodel and anevaluationmodel into the evaluation deployments.gateway_http.rsnow refreshes a gateway reporting one of each, saves a Signals config on thedecisionsmodel and still rejects a chat model. There are also unit tests for both predicatesCaveats
The bundled
model_catalog.jsonparses withlitellm-model-catalogpinned at3969348, which has noMode::Decisions. Onedecisionsrow makesCatalog::parsefail for the whole file, so refreshing that snapshot after LiteLLM addsdecisionsrows needs the pin bumped past BerriAI/litellm#45474 first. The same bump should letdecisions/src/transport.rsacceptMode::Decisionsnext toMode::EvaluationLink to Devin session: https://app.devin.ai/sessions/290da858f1bd412dbb3b36b7d880974c
Open in Devin Desktop: https://app.devin.ai/desktop/session/290da858f1bd412dbb3b36b7d880974c?variant=devin
Requested by: @kerry-berri
Note
Devin errored when opening this Pull Request as kerry-berri.
As a fallback, Devin opened this PR as itself.