Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptEngine: added FileSystemWatcher, optionally including subdirectories and… #8

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

Theadd
Copy link
Contributor

@Theadd Theadd commented Apr 10, 2022

The entries added to the com.bepis.bepinex.scriptengine.cfg file can be used as this PR's description:

## Suppress sending log messages to console except for the error ones.
# Setting type: Boolean
# Default value: false
QuietMode = true

## Listens for changes to the scripts directory and reloads all plugins automatically.
# Setting type: Boolean
# Default value: false
EnableFileSystemWatcher = true

## Include also subdirectories under the scripts folder.
# Setting type: Boolean
# Default value: false
IncludeSubdirectories = true

…ption to restrict console logging only to error messages
Copy link
Contributor

@ghorsington ghorsington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

This looks otherwise fine to me sans one note. Please check it out before I can merge this.

@Theadd Theadd requested a review from ghorsington April 24, 2022 02:25
@DemoJameson
Copy link

I think this pr is ready to merge

@Theadd Theadd requested review from ManlyMarco and removed request for ghorsington November 27, 2022 04:29
@Theadd Theadd requested review from ghorsington and removed request for ManlyMarco December 30, 2022 04:58
Copy link
Member

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, the PR looks good. Thank you!

@ManlyMarco ManlyMarco merged commit c6a608c into BepInEx:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants