Skip to content

chore(deps): stub out node-forge, which has no fixed release - #290

Merged
Benyamen9 merged 2 commits into
mainfrom
chore/stub-node-forge
Oct 12, 2026
Merged

Benyamen9 merged 2 commits into
mainfrom
chore/stub-node-forge

Conversation

@Benyamen9

Copy link
Copy Markdown
Owner

Why: node-forge ≤ 1.4.0 carries GHSA-86w9-cpqp-85rv (high: RSA PKCS#1 v1.5 signature forgery), and no patched release exists. The upstream fix, digitalbazaar/forge#1152, is still unmerged.

Where it's used: its only user here is listhen (via nitropack), and only to generate self-signed certificates for nuxt dev --https.

Change:

  • vendor/node-forge/ is our own stand-in package with no dependencies. Loading it is harmless; reading any forge API throws an error that explains why.
  • Wired as a dev dependency file:./vendor/node-forge plus overrides: { "node-forge": "$node-forge" }. A relative file: path inside overrides alone resolves against listhen's folder, so it needs the $ reference.
  • The Dockerfile copies vendor/ before npm ci.

Cost: nuxt dev --https stops working until the stand-in is removed. Nothing else changes: forge is not in .output.

Verified:

  • On Linux: npm ci on a clean copy exits 0, node_modules/node-forge links to ../vendor/node-forge, and npm audit no longer lists node-forge.
  • listhen still loads.
  • On Windows after npm ci: typecheck 0, eslint clean, unit tests pass, nuxt build 0.
  • nuxt dev serves / with HTTP 200, and DevTools loads.

Remove when node-forge ships a fix: delete vendor/, the dev dependency, the override and the Dockerfile line.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GpshKC4WXpYdXWj6Ptew4q

Benyamen9 and others added 2 commits October 12, 2026 20:03
node-forge <=1.4.0 carries GHSA-86w9-cpqp-85rv with no patched version.
Its only user is listhen, for `nuxt dev --https` self-signed certs. A
local stand-in replaces it via overrides; touching it throws.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GpshKC4WXpYdXWj6Ptew4q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GpshKC4WXpYdXWj6Ptew4q
@Benyamen9
Benyamen9 enabled auto-merge (squash) October 12, 2026 18:04
@Benyamen9
Benyamen9 merged commit 11713d0 into main Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant