Fixing a possible bug that can interfere with mob spawns in bskyblock generated worlds #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkGenerator has a boolean called shouldGenerateMobs() and has the description, "Gets if the server should generate Vanilla mobs after this ChunkGenerator."
I've worked a couple of days ago with a custom world generator and I noticed the default mob spawn was not behaving right. I was on hard diff with 0 light level on the entire map and there were very few spawns. I found out that if you don't override shouldGenerateMobs() is just returns false by default.
It does seem to interfere with normal mob spawn in certain cases, but not always which seems very strange to me. But I do remember running BSkyBlock and having mob spawn issues for no real reason, I've also seen people complain about this kind of stuff in the discord as well.
Needs some testing, and perhaps digging through src to find out what's really happening. Though I doubt just leaving this setting on true would have any negative effects.