fix: add missing vstest outcomes and fix directory heuristic for RID paths

[BenjaminMichaelis]

Why

Two bugs were found by comparing TrxLib's object model against the upstream vstest TRX ObjectModel (commit ba0077af), validated by tracing the vstest source through Converter.ToOutcome() and XmlPersistence.SaveSimpleField().

---

Bug 3 -- Unknown vstest outcomes silently coerced to NotExecuted

TrxParser's outcome switch had a catch-all _ => TestOutcome.NotExecuted that silently swallowed 8 distinct vstest states. TestOutcome.cs only had 6 values while the upstream TRX enum has 14.

Fix: Added the 8 missing enum values (Error, Aborted, NotRunnable, Disconnected, Warning, Completed, InProgress, PassedButRunAborted) and corresponding switch arms.

Non-obvious nuance: vstest never writes outcome="Error" as a literal attribute. Error is ordinal 0 (the enum default), so XmlPersistence.SaveSimpleField() omits the attribute entirely when outcome is Error. A <UnitTestResult> with no outcome= attribute is the real-world form of the Error state (e.g., when attaching result files fails). The parser now maps null -> TestOutcome.Error instead of NotExecuted.

This also resolves an internal inconsistency: Counters.cs already tracked all 14 vstest outcomes at the aggregate level, but TestOutcome had no matching per-result values.

---

Bug 4 -- Hardcoded 3-level traversal breaks for RID-qualified and publish output paths

TrxParser derived TestProjectDirectory by walking exactly 3 levels up from the codeBase DLL path, which only works for bin/{config}/{tfm}/. It returns the wrong directory for:

• bin/{config}/{tfm}/{rid}/ (depth 4 -- self-contained builds)
• bin/{config}/{tfm}/publish/ (depth 4 -- publish output)
• bin/{config}/{tfm}/{rid}/publish/ (depth 5 -- self-contained publish)

Fix: Replaced the for (i < 3) loop with a while that walks up until it finds the bin directory, then returns its parent. This handles all standard .NET SDK output layouts regardless of depth.

---

Tests

• Regression tests were written first (TDD-style) as failing proofs, then the fixes were applied.
• Bug 3: 3 outcome tests strengthened from NotBe(NotExecuted) to Be(exact value); added Bug_Parse_MissingOutcomeAttribute_MapsToError for the real vstest serialization of the Error state.
• Bug 4: Added tests for publish (depth 4) and RID+publish (depth 5) path layouts.
• All 59 tests pass.

[Copilot]

Pull request overview

Fixes two bugs in TrxParser: (1) missing vstest TestOutcome enum values that caused 8 distinct outcome states (including Error) plus absent-attribute serialization to be silently coerced into NotExecuted, and (2) a hardcoded 3-level directory walk that misidentified the test project root for RID-qualified and publish output layouts. The TRX object model is brought in line with upstream vstest, and regression tests (TDD-style) accompany each fix.

Changes:

• Added 8 new values to TestOutcome (Error, Aborted, NotRunnable, Disconnected, Warning, Completed, InProgress, PassedButRunAborted) with XML docs explaining each.
• Extended TrxParser's outcome switch with the new cases, and mapped a missing outcome= attribute (null) to TestOutcome.Error to match vstest's XmlPersistence default-value omission behavior.
• Replaced the fixed 3-level upward traversal with a while-loop that walks up until it finds a bin directory, then returns its parent — covering classic, RID, publish, and RID+publish output layouts.
• Added a new KnownBugsTests.cs suite with outcome-parsing and project-directory regression tests, plus a TempTrxFile helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
TrxLib/TestOutcome.cs	Adds 8 new enum values matching the upstream vstest TRX outcomes, with XML docs.
TrxLib/TrxParser.cs	Maps new outcomes (and missing attribute → Error); replaces fixed 3-level path traversal with a bin-seeking walk.
TrxLib.Tests/KnownBugsTests.cs	New regression tests for outcome parsing and RID/publish path resolution; includes TempTrxFile helper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.