[Feature] Add navigation witness #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleformichelli
force-pushed
the
feature/navigation-witness
branch
2 times, most recently
from
16b06e5
to
8f86552
Compare
Podfile.lock
Outdated
| - Tempura (from `.`) | ||
| - Tempura (~> 6.0) |
There was a problem hiding this comment.
[i] Maybe let's have TempuraTesting point to the local Tempura in the Podfile, and check that everything is set up correctly in the podspec
danieleformichelli
force-pushed
the
feature/navigation-witness
branch
from
8f86552
to
bb1a98c
Compare
FEC-bendingspoons
suggested changes
Nov 26, 2020
| // MARK: - Wrapped | ||
|
|
||
| /// Wraps any object into a reference-type object | ||
| public class Wrapped<T> { |
There was a problem hiding this comment.
[i] If you look in Ramen there is a Box type that does this but it also has dynamic dispatch to the underlying value (which is kinda cool to have). I'd put that here
There was a problem hiding this comment.
Replaced Wrapped with ad hoc NavigationRequests type for improved ergonomic
FEC-bendingspoons
approved these changes
Nov 27, 2020
…nd Hide dispatchable
…n-live implementations
LorDisturbia
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expose the navigation as a protocol witness to facilitate testing of the app logic
Changes
Add NavigationWitness struct
Tasks